Skip to content

Conversation

@prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Jul 2, 2025

Issue link

This Pull Request is linked to issue (URL): #4333

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@Yury-Fridlyand Yury-Fridlyand added Compatibility 🧭 Tasks & PRs for compatibility of GLIDE with other clients java ☕ issues and fixes related to the java client labels Jul 3, 2025
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving marked this pull request as ready for review July 22, 2025 23:21
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner July 22, 2025 23:21
@prateek-kumar-improving prateek-kumar-improving changed the title Java: compatibility layer Java: Jedis compatibility layer Jul 22, 2025
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from high level review.
I suggest changing the title to indicate that this is the initial check-in, since there are still some commented-out code sections.

@prateek-kumar-improving prateek-kumar-improving changed the title Java: Jedis compatibility layer Java: Jedis compatibility layer initial config code and get/set commands. Jul 23, 2025
@prateek-kumar-improving prateek-kumar-improving merged commit fb9f460 into main Jul 23, 2025
21 of 22 checks passed
@prateek-kumar-improving prateek-kumar-improving deleted the java/compatibility-layer branch July 23, 2025 16:43
@prateek-kumar-improving
Copy link
Collaborator Author

LGTM from high level review. I suggest changing the title to indicate that this is the initial check-in, since there are still some commented-out code sections.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compatibility 🧭 Tasks & PRs for compatibility of GLIDE with other clients java ☕ issues and fixes related to the java client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants