Skip to content

Java: Refactor Jedis compatibility layer code to remove duplicate code #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2025
Merged

Java: Refactor Jedis compatibility layer code to remove duplicate code #4609

merged 1 commit into from
Aug 17, 2025

Conversation

@prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Aug 15, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #4333

Description

  1. Added generic function for command code to call Glide client.
  2. convertToGlideStringArray helper function added.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@prateek-kumar-improving
Java: Refactor Jedis compatibility layer code to remove duplicate code
f7dc4a1 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving mentioned this pull request Aug 15, 2025
Closed
29 tasks
@prateek-kumar-improving prateek-kumar-improving marked this pull request as ready for review August 15, 2025 18:57
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner August 15, 2025 18:57
yipin-chen
yipin-chen approved these changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateek-kumar-improving prateek-kumar-improving merged commit 1d46adb into main Aug 17, 2025
21 of 22 checks passed
@prateek-kumar-improving prateek-kumar-improving deleted the java/jedis-compatibility-refactor-code branch August 17, 2025 14:24
@prateek-kumar-improving prateek-kumar-improving added java ☕ issues and fixes related to the java client Compatibility 🧭 Tasks & PRs for compatibility of GLIDE with other clients labels Aug 18, 2025
alexr-bq pushed a commit that referenced this pull request Aug 25, 2025
@prateek-kumar-improving @alexr-bq
Java: Refactor Jedis compatibility layer code to remove duplicate code (
269225b 
#4609)

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
alexr-bq pushed a commit that referenced this pull request Sep 3, 2025
@prateek-kumar-improving @alexr-bq
Java: Refactor Jedis compatibility layer code to remove duplicate code (
7a12b81 
#4609)

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
xShinnRyuu pushed a commit that referenced this pull request Sep 24, 2025
@prateek-kumar-improving @xShinnRyuu
Java: Refactor Jedis compatibility layer code to remove duplicate code (
7226df8 
#4609)

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jduo jduo jduo approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees

No one assigned

Labels

Compatibility 🧭 Tasks & PRs for compatibility of GLIDE with other clients java ☕ issues and fixes related to the java client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prateek-kumar-improving @jduo @yipin-chen