Skip to content

Conversation

@jbrinkman
Copy link
Collaborator

Summary

Adds comprehensive AGENTS.md files to provide AI agents and developers with the minimum but sufficient context to work productively in the Valkey GLIDE repository and its language bindings.

Changes

Root Repository

  • /AGENTS.md - Unified context for the mono-repo covering all language bindings, build system, and cross-language development

Language Bindings

  • /java/AGENTS.md - Java client context (Gradle, JNI, platform classifiers, Spotless/SpotBugs)
  • /node/AGENTS.md - Node.js client context (npm, TypeScript, NAPI-RS, async frameworks)
  • /python/AGENTS.md - Python client context (async/sync clients, dev.py CLI, PyO3/CFFI)
  • /go/AGENTS.md - Go client context (Make targets, CGO, cross-compilation)
  • /java/jedis-compatibility/AGENTS.md - Jedis compatibility layer context (drop-in replacement API)

Content Structure

Each AGENTS.md file includes:

  • Repository/component overview and architecture
  • Build and test commands (preferred targets + raw equivalents)
  • Contribution requirements (DCO signoff, conventional commits)
  • Code quality requirements (linters, formatters)
  • Guardrails and policies (generated outputs, security)
  • Project structure overview
  • Quality gates checklist
  • Quick facts for AI reasoners
  • Links to additional documentation

Key Features

  • Accurate Commands: All build/test commands extracted from actual Makefiles, package.json, build.gradle files
  • Platform-Specific: Includes Alpine/MUSL, platform classifiers, cross-compilation guidance
  • Language-Specific: Respects each language's conventions while maintaining consistency
  • AI-Optimized: Structured format designed for both human and AI agent consumption
  • Actionable: Quality gates provide clear pass/fail checklists

Benefits

  1. Improved Developer Experience: Clear, actionable guidance for contributors
  2. Consistent Contribution Process: Standardized requirements across all language bindings
  3. Reduced Onboarding Time: Essential context in single, skimmable documents
  4. AI Tool Compatibility: Optimized for AI-powered development tools
  5. Quality Assurance: Clear checklists prevent common contribution issues

Testing

  • All commands verified against actual build configurations
  • Files follow repository conventions and existing documentation patterns
  • Content extracted from authoritative sources (Makefiles, package configs, etc.)

Closes #4738

Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node and Python LGTM

Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the go document, assuming all comments addressed

@jbrinkman jbrinkman changed the base branch from release-2.1 to main September 18, 2025 17:06
jamesx-improving and others added 6 commits October 3, 2025 12:02
* Go: Switch to MUSL binary

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* rustup add musl targets

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* lint

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* rustup add musl targets in Makefile

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Add pathing

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Trigger CodeQL on main

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update CI

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Fix typo

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Fix typo

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Modify CD

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Modify CD

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Modify CD

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Modify CD

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update docs

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Format

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Fix

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Fix

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Address feedback

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

* Update doc

Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
Co-authored-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
* Java: Compatibility layer module

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: fix integration tests

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql for java code

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix codeql java build

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Update java cd

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: lint issues fixed

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Add signing configuration to jedis-compatibility build.gradle

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: update dependency

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Update valkey-glide-jedis-compatibility file path

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

* Java: Fix build.gradle publishing code

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
- Add root AGENTS.md with unified context for mono-repo
- Add Java AGENTS.md with Gradle, JNI, and platform classifier guidance
- Add Node.js AGENTS.md with npm, TypeScript, and NAPI-RS context
- Add Python AGENTS.md with async/sync clients and dev.py CLI
- Add Go AGENTS.md with Make targets, CGO, and cross-compilation
- Add Jedis compatibility AGENTS.md for drop-in replacement API

Each file provides AI agents and developers with minimum but sufficient
context including build commands, contribution requirements, quality gates,
and language-specific development patterns.

Closes #4738

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Co-authored-by: James Xin <james.xin@improving.com>
Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
Co-authored-by: James Xin <james.xin@improving.com>
Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
@jbrinkman jbrinkman force-pushed the jbrinkman/add-agents-md-files branch from d183641 to f448687 Compare October 3, 2025 16:04
@jbrinkman jbrinkman merged commit 7664ec0 into main Oct 3, 2025
60 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AGENTS.md files for agentic tools across language bindings

8 participants