-
Notifications
You must be signed in to change notification settings - Fork 117
feat: add AGENTS.md files for agentic tools across language bindings #4739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yipin-chen
approved these changes
Sep 16, 2025
Collaborator
yipin-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node and Python LGTM
jduo
reviewed
Sep 16, 2025
jamesx-improving
approved these changes
Sep 16, 2025
Collaborator
jamesx-improving
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the go document, assuming all comments addressed
prateek-kumar-improving
approved these changes
Sep 16, 2025
avifenesh
reviewed
Sep 17, 2025
avifenesh
reviewed
Sep 17, 2025
avifenesh
reviewed
Sep 17, 2025
* Go: Switch to MUSL binary Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * rustup add musl targets Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * lint Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * rustup add musl targets in Makefile Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Add pathing Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Trigger CodeQL on main Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update CI Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Fix typo Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Fix typo Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Modify CD Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Modify CD Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Modify CD Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Modify CD Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update docs Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Format Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Fix Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Fix Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Address feedback Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> * Update doc Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> --------- Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> Co-authored-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com> Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
* Java: Compatibility layer module Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: fix integration tests Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql for java code Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix codeql java build Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Update java cd Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: lint issues fixed Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Add signing configuration to jedis-compatibility build.gradle Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: update dependency Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Update valkey-glide-jedis-compatibility file path Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> * Java: Fix build.gradle publishing code Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> --------- Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
- Add root AGENTS.md with unified context for mono-repo - Add Java AGENTS.md with Gradle, JNI, and platform classifier guidance - Add Node.js AGENTS.md with npm, TypeScript, and NAPI-RS context - Add Python AGENTS.md with async/sync clients and dev.py CLI - Add Go AGENTS.md with Make targets, CGO, and cross-compilation - Add Jedis compatibility AGENTS.md for drop-in replacement API Each file provides AI agents and developers with minimum but sufficient context including build commands, contribution requirements, quality gates, and language-specific development patterns. Closes #4738 Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Co-authored-by: James Xin <james.xin@improving.com> Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
Co-authored-by: James Xin <james.xin@improving.com> Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
d183641 to
f448687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive AGENTS.md files to provide AI agents and developers with the minimum but sufficient context to work productively in the Valkey GLIDE repository and its language bindings.
Changes
Root Repository
/AGENTS.md- Unified context for the mono-repo covering all language bindings, build system, and cross-language developmentLanguage Bindings
/java/AGENTS.md- Java client context (Gradle, JNI, platform classifiers, Spotless/SpotBugs)/node/AGENTS.md- Node.js client context (npm, TypeScript, NAPI-RS, async frameworks)/python/AGENTS.md- Python client context (async/sync clients, dev.py CLI, PyO3/CFFI)/go/AGENTS.md- Go client context (Make targets, CGO, cross-compilation)/java/jedis-compatibility/AGENTS.md- Jedis compatibility layer context (drop-in replacement API)Content Structure
Each AGENTS.md file includes:
Key Features
Benefits
Testing
Closes #4738