-
Notifications
You must be signed in to change notification settings - Fork 62
adds revises downloads page, adds package page, updates package data #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Do we really want to be maintaining that dot array? I suppose either:
|
@madolson I do think it's necessary: the gap it fills is that our release pages show the places you can get a given version; I think that's reasonably required information. However, because some package managers lag considerably (e.g. Ubuntu currently only has 7.2.5), looking only at a single version could lead someone to believe that Valkey isn't available in a given package manager. Originally, I did consider having this information only appear on the release page with a row for each distro and the last version supported. However, this got very complicated to present multiple version lines. The dot array, IMHO, is the easiest way to represent the entire landscape. Also, the dot table is actually just a representation of the same data in the package manager table, so it's no extra maintenance is needed, new package managers automatically appear on this table as soon as they are added to any version. |
I've been investigating the maintenance concerns raised by @madolson. A lot of this is source from repology we can build up the data using their API and put it into a GitHub Action. Tinkering that I was able to pull the data: import asyncio
import repology_client
import json
async def main():
packages = await repology_client.get_packages(project="valkey")
for package in packages:
print("---")
print(package.repo.split("_")[0])
repo_remainder = package.repo.split("_")[1:]
print("_".join(repo_remainder))
print(package.version)
asyncio.run(main()) This PR relies on getting the availability of Valkey in particular package managers where as repology returns repos with their latest version. It just needs a little extra to transform the data. |
@madolson @zuiderkwast Is it relevant? Should I try to embed it? I'm not sure if we can make it look nice as it is now, it will be parsing from json to md, then embed the dynamic md as a code block, complicating the status, but feasible. But if it's relevant, I can take it. |
@avifenesh We could use a badge from repology instead? Then we don't need to update it ourselves...
It renders like this: |
@zuiderkwast Yes, that looks good, actually. We can leave the instruction of how to, and just add those tags. So it's visible in the same place. |
@avifenesh I kind of think we should just put this badge at the bottom of the page with a link. |
That looks fine to me. |
Description
This revises. the downloads page extensively.
artifact_source
from each release files to a central data file since it never changesScreenshots:
Package Manager page:

New section on downloads and each release:

Issues Resolved
#131
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.