adds a performance section to the homepage #425

stockholmux · 2025-12-03T17:46:31Z

Description

Adds tiles to the what's new section for performance dashboard links
fixes inconsistencies in CSS (underscore vs dash, corner radius)

Issues Resolved

#421

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

roshkhatri · 2025-12-10T23:25:09Z

I have updated the PR with a /performance page for the website and the card on the home page,
The Website would look as under:

Followed by the /performance/ page:

Please add your feedback, I will also update the iframe links once we are ready to merge

makubo-aws · 2025-12-10T23:54:07Z

Super cool. Would be great to link to relevant blogs to performance and hash tables in case readers want to dive deeper.

madolson · 2025-12-11T08:45:58Z

_data/perf.toml

+title = "Throughput Across Versions"
+iframe_url = "https://df0m5orgq2d38.cloudfront.net/public-dashboards/e6e8ec1f88954ddd8a67df1ab4966eb2"
+description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."
+methodology = "These metrics are generated using the valkey-perf-benchmark tool on a c8g.metal.2xl instance, running a matrix of configurations that vary pipelining (1, 10), I/O threading (1, 9), and data sizes 512 bytes. To further stabilize results, we apply IRQ tuning by pinning network interrupts away from CPUs dedicated to the server process, and we isolate the server and benchmark client on separate NUMA nodes to remove L3 cache contention. This controlled methodology ensures consistent, repeatable comparisons across versions and makes performance gains or regressions easier to attribute to real code changes rather than environmental variability."


Suggested change

methodology = "These metrics are generated using the valkey-perf-benchmark tool on a c8g.metal.2xl instance, running a matrix of configurations that vary pipelining (1, 10), I/O threading (1, 9), and data sizes 512 bytes. To further stabilize results, we apply IRQ tuning by pinning network interrupts away from CPUs dedicated to the server process, and we isolate the server and benchmark client on separate NUMA nodes to remove L3 cache contention. This controlled methodology ensures consistent, repeatable comparisons across versions and makes performance gains or regressions easier to attribute to real code changes rather than environmental variability."

methodology = "These metrics are generated using the valkey-perf-benchmark tool on an AWS c8g.metal.24xl instance, running a matrix of configurations that vary pipelining (1, 10), I/O threading (1, 9), and with a data size of 512 bytes. To further stabilize results, we apply IRQ tuning by pinning network interrupts away from CPUs dedicated to the server process, and we isolate the server and benchmark client on separate NUMA nodes to remove L3 cache contention."

Include a link to the valkey-perf-benchmark tool.

The last sentence adds nothing.

We also don't test the full matrix, since IO thread 9 and Pipelining 1 is not present. Is that intentional?

We do have that data, but thats intentional, I can add it

madolson · 2025-12-11T08:46:29Z

_data/perf.toml

+[[sections]]
+title = "Memory Overhead Across Versions"
+iframe_url = "https://df0m5orgq2d38.cloudfront.net/public-dashboards/1e3d87a62b794ce9aa81281d8399e4bf"
+description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."


Suggested change

description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."

description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features."

What Performance SLO?

I meant Service Level Objective, but yeah can be removed

madolson · 2025-12-11T08:46:56Z

_data/perf.toml

+description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."
+methodology = "These metrics are generated using the valkey-perf-benchmark tool on a c8g.metal.2xl instance, running a matrix of configurations that vary pipelining (1, 10), I/O threading (1, 9), and data sizes 512 bytes. To further stabilize results, we apply IRQ tuning by pinning network interrupts away from CPUs dedicated to the server process, and we isolate the server and benchmark client on separate NUMA nodes to remove L3 cache contention. This controlled methodology ensures consistent, repeatable comparisons across versions and makes performance gains or regressions easier to attribute to real code changes rather than environmental variability."
+
+[[sections]]


Memory overhead is not performance. I'm not sure why we're including this here.

madolson · 2025-12-11T08:47:43Z

_data/perf.toml

+title = "Memory Overhead Across Versions"
+iframe_url = "https://df0m5orgq2d38.cloudfront.net/public-dashboards/1e3d87a62b794ce9aa81281d8399e4bf"
+description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."
+methodology = "These benchmarks are generated by starting an empty instance of Valkey for each test, measuring memory usage, then adding 3 million string items of a certain data size, then measuring Valkey memory usage again. We take the increase in memory use, divide by the number of items, and subtract the size of the user data (key and value) to get the extra overhead bytes Valkey uses to track and organize the data. For this graph, we tested every value size from 8B to 128B inclusive, then averaged the numbers for each range in this chart."


I'm still confused why this isn't an integration test. Why is this here? What is this methodology?

This was with the intention of showing how we have improved valkey for throughput and memory utilisation

We can surely add an integration test for it too

Sure, it's just not really performance. Feels like maybe it should be on a separate page then.

madolson · 2025-12-11T08:50:35Z

_data/perf.toml

+[[sections]]
+title = "Throughput Across Versions"
+iframe_url = "https://df0m5orgq2d38.cloudfront.net/public-dashboards/e6e8ec1f88954ddd8a67df1ab4966eb2"
+description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."


Suggested change

description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."

description = "This dashboard visualizes throughput trends across Valkey versions. It helps compare key releases side by side, highlight performance gains from new features."

Performance SLOs is a very weird thing to call out.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

roshkhatri · 2025-12-11T20:27:37Z

Applied the suggestions and also added the links to the relevant blogs.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

madolson

I'm okay with everything outside the memory overhead in this version. I still don't think we should conflate them in the same dashboard as performance, and I also don't know if I agree with the methodology.

roshkhatri · 2025-12-12T19:59:46Z

I'm okay with everything outside the memory overhead in this version. I still don't think we should conflate them in the same dashboard as performance, and I also don't know if I agree with the methodology.

We can remove the memory overhead from this page and we can think of ways to add it with a different mythology in the future

We can also keep adding more performance related things on this page in the future

roshkhatri · 2025-12-12T21:38:18Z

I have removed the memory overhead from this PR, let me know if we need to add/remove more or we can merge this.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

stockholmux and others added 3 commits December 3, 2025 10:10

adds a performance section to the homepage

2e2ad8c

Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>

adds additional comment about markdown

c91be8b

Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>

Adds /performance page with the dashboards

f8e8f8a

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

madolson reviewed Dec 11, 2025

View reviewed changes

Addressing feedbacks

3d93acb

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

update dashboard link

ab75345

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

madolson reviewed Dec 12, 2025

View reviewed changes

removes memory overhead metrics

0d84d14

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>

roshkhatri force-pushed the performanc branch from 75299af to 0d84d14 Compare December 12, 2025 21:44

roshkhatri marked this pull request as ready for review December 13, 2025 00:05

	description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features. Use it when evaluating whether a new version meets your performance SLOs before rollout."
	description = "This dashboard visualizes Memory Efficiency trends across Valkey versions. It helps compare releases side by side, highlight Memory Efficiency gains from new features."

adds a performance section to the homepage #425

Are you sure you want to change the base?

adds a performance section to the homepage #425

Conversation

stockholmux commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

roshkhatri commented Dec 10, 2025

Uh oh!

makubo-aws commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roshkhatri Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roshkhatri commented Dec 11, 2025

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

roshkhatri commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roshkhatri commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stockholmux commented Dec 3, 2025 •

edited

Loading

roshkhatri Dec 11, 2025 •

edited

Loading

roshkhatri commented Dec 12, 2025 •

edited

Loading

roshkhatri commented Dec 12, 2025 •

edited

Loading