Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache docker layers and avoid re-downloading them for each job #86

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

aiven-sal
Copy link
Member

@aiven-sal aiven-sal commented Sep 4, 2024

Description of change

Sometimes the CI fails because Docker doesn't respond.
It could be because we download many docker images in every job and we have 58 jobs now.
With this commit, the image layers will be downloaded during nightly builds and cached.

@aiven-sal aiven-sal force-pushed the aiven-sal/cache branch 3 times, most recently from 540e936 to 2b3e5b3 Compare September 4, 2024 16:03
@aiven-sal aiven-sal added the ci label Sep 4, 2024
@aiven-sal aiven-sal force-pushed the aiven-sal/cache branch 2 times, most recently from 87ac3b4 to 5e0ef01 Compare September 4, 2024 16:12
@aiven-sal aiven-sal marked this pull request as draft September 4, 2024 16:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (cd24489) to head (f90519d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files         132      132           
  Lines       34400    34400           
=======================================
  Hits        25842    25842           
  Misses       8558     8558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal aiven-sal force-pushed the aiven-sal/cache branch 7 times, most recently from 2fb13b8 to 9cae236 Compare September 6, 2024 16:47
Sometimes the CI fails because Docker doesn't respond.
It could be because we download many docker images in every
job and we have 58 jobs now.
With this commit, the image layers will be downloaded
during nightly builds and cached.

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
@aiven-sal aiven-sal marked this pull request as ready for review September 9, 2024 09:03
@aiven-sal aiven-sal enabled auto-merge September 9, 2024 09:04
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aiven-sal aiven-sal merged commit f520399 into main Sep 9, 2024
76 checks passed
@aiven-sal aiven-sal deleted the aiven-sal/cache branch September 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants