Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase fudge factors #88

Merged
merged 1 commit into from
Sep 9, 2024
Merged

tests: increase fudge factors #88

merged 1 commit into from
Sep 9, 2024

Conversation

aiven-sal
Copy link
Member

Description of change

Make some tests less likely to fail.
Maybe we should just drop these tests.
But let's see if we can make them less flaky.

maybe we should just drop these tests.
But let's see if we can make them less flaky.

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (f520399) to head (08e8f9e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files         132      132           
  Lines       34400    34400           
=======================================
  Hits        25842    25842           
  Misses       8558     8558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if those factors are important. Like, if there are situations when we do have to do something in a certain amount of time and no longer.

If you're positive these changes won't hide any bug in valkey-py, I'm fine with this.

@aiven-sal
Copy link
Member Author

You can't guarantee that a blocking operation with a timeout will not take more than timeout+delta, unless you have an RTOS and you are not using python. If you rely on the fact that this timeouts will return "on time" you already have a bug in your code.

In fact, I'm not sure it makes any sense at all to check how much time passed in those tests, but if this commit fixes the flaky tests we can leave them.
If they fail again, I'll just drop them completely.
The actual amount of time that those operation take is completely outside of our control and influenced by stuff (i.e. other processes running on the machine) that have nothing to do with valkey-py.

@aiven-sal aiven-sal merged commit 0941032 into main Sep 9, 2024
75 checks passed
@aiven-sal aiven-sal deleted the aiven-sal/flakytests branch September 9, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants