Make valkey-py install the correct dependencies in Python 3.11.0 to Python 3.11.3 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirav-ark-biotech
requested review from
aiven-sal,
mkmkme and
ahmedsobeh
as code owners
nirav-ark-biotech
force-pushed
the
support_python_3.11.0-to-3.11.3
branch
from
a2f7f5b to
e79e8d3
Compare
nirav-ark-biotech
changed the title
mkmkme
previously approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 75.12% 75.12%
=======================================
Files 132 132
Lines 34398 34398
=======================================
Hits 25840 25840
Misses 8558 8558 ☔ View full report in Codecov by Sentry. |
|
Hi! |
Signed-off-by: Nirav Ark <nirav@ark-biotech.com>
aiven-sal
force-pushed
the
support_python_3.11.0-to-3.11.3
branch
from
e79e8d3 to
f3fc0bb
Compare
mkmkme
requested changes
Sep 11, 2024
Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
aiven-sal
force-pushed
the
support_python_3.11.0-to-3.11.3
branch
from
f3fc0bb to
0c76703
Compare
Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
there are some issues with asyncio-timeout in 3.11.1 and 3.11.2 We need to test at least 3.11.1 separatly Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
aiven-sal
approved these changes
Sep 11, 2024
mkmkme
approved these changes
Sep 11, 2024
|
Great, thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just happened to be using Python 3.11.1 while using valkey-py.
The PR #87 broke my CI/CD pipeline (when upgrading to valkey-py
6.1bc the codebase, invalkey-py/valkey/asyncio/connection.py
Line 31 in 03320e6
just so happens to check whether or not we're 3.11.3 and above.
If you are in Python 3.11.0 - 3.11.2, you go into the else and this code fails if async timeout is not installed
so we need to still to install
async-timeoutif python version < 3.11.3Pull Request check-list
Description of change