Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert mmap_rnd bits back to default value #519

Closed
madolson opened this issue May 20, 2024 · 0 comments · Fixed by #520
Closed

Revert mmap_rnd bits back to default value #519

madolson opened this issue May 20, 2024 · 0 comments · Fixed by #520
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated

Comments

@madolson
Copy link
Member

madolson commented May 20, 2024 •
edited
Loading

I introduced a change back in march to reduce the entropy of ASLR, 3f725b8, because ASAN didn't support it. It looks like the issue I linked has been resolved, so we should be able to revert my commit now.

We just need to revert that commit and test that the CI works as expected.
@madolson madolson added help wanted External contributions would be appreciated good first issue Good for newcomers labels May 20, 2024
enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue May 20, 2024
@enjoy-binbin
Revert mmap_rnd bits back to default value in CI
3a4ba2b 
In 3f725b8, we introduced a change back in march to reduce the
entropy of ASLR, because ASAN didn't support it. Now the vm.mmap_rnd_bits
was reverted in actions/runner-images#9491 so can remove this changes.

Closes valkey-io#519.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@enjoy-binbin enjoy-binbin mentioned this issue May 20, 2024
Merged
madolson pushed a commit that referenced this issue May 20, 2024
@enjoy-binbin
Revert mmap_rnd bits back to default value in CI (#520)
e7e5a10 
In 3f725b8, we introduced a change back in march to reduce the
entropy of ASLR, because ASAN didn't support it. Now the
vm.mmap_rnd_bits
was reverted in actions/runner-images#9491 so can remove this changes.

Closes #519.

Signed-off-by: Binbin <binloveplay1314@qq.com>
adetunjii pushed a commit to adetunjii/valkey that referenced this issue May 22, 2024
@enjoy-binbin @adetunjii
Revert mmap_rnd bits back to default value in CI (valkey-io#520)
b12f76b 
In 3f725b8, we introduced a change back in march to reduce the
entropy of ASLR, because ASAN didn't support it. Now the
vm.mmap_rnd_bits
was reverted in actions/runner-images#9491 so can remove this changes.

Closes valkey-io#519.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert mmap_rnd bits back to default value in CI enjoy-binbin/valkey
1 participant
@madolson