-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup methods and Python version requirements #69
Conversation
- move project information from setup.py to pyproject.toml - set Python 3.9 as minimum supported version (in line with new NumPy version support) - switch versioning to use setuptools_scm (version created from git tag)
…pinning that will be unneccsary for Python >=3.9
@vallis any update on getting this merged and a new version tagged + conda-forge built? The lack of availability with Python 3.11 is causing some IPTA / NANOGrav infrastructure issues. @mattpitkin Is there a reason why this pull request excludes 3.12? ~ Joe G. |
@JPGlaser there's no reason for this to exclude python 3.12. I can add it into the github action CI job and check that it builds |
I've included Python 3.12 in the test suite (which passes) and added the Python 3.12 classifier in |
Everything looks good on my end. @vallis any chance we can get this merged sooner than later? ~ Joe G. |
Hi Matt and Joe, This request looks fine. I'll look over it in more details in a bit and then pull the merge the pull request. Please bear with me, if stuff breaks, as I am not as careful and knowledgeable as Michele with libstempo. |
@siyuan-chen Great, thanks for this. I'm happy to merge this MR and generate the new release if you want (Michele has given me admin access to the repo and the libstempo PyPI)? |
@mattpitkin I just merged this. Should be fine. As for updating the version, I think you can go ahead with 3.5.0 and also do the pypi release (I am not so familiar with that process). |
1 similar comment
@mattpitkin I just merged this. Should be fine. As for updating the version, I think you can go ahead with 3.5.0 and also do the pypi release (I am not so familiar with that process). |
In this MR, I have:
setup.py
intopyproject.toml
(including building with NumPy v2.0.0, which allows NumPy v2.0.0 compatibility, while still supporting running with earlier versions.)@vallis - are you happy for these changes to be made?
If/when merged, I'd propose creating a new v3.5.0 release.