Allow filtering Redis list items on read #39
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 91.11% 91.70% +0.59%
==========================================
Files 25 25
Lines 855 880 +25
Branches 115 82 -33
==========================================
+ Hits 779 807 +28
+ Misses 45 44 -1
+ Partials 31 29 -2 ☔ View full report in Codecov by Sentry. |
ruksi
force-pushed
the
read-list-filter
branch
from
244e5ab to
bdc9d20
Compare
| assert list(last_four) == [b"2", b"3", b"4", b"5"] | ||
|
|
||
| last_everything = read_list(redis, random_queue_name, last_n=999_999) | ||
| assert list(last_everything) == [b"0", b"1", b"2", b"3", b"4", b"5"] |
There was a problem hiding this comment.
these are all spanning just one chunk, does it behave correctly if it requests multiple chunks? I have a hunch that it's not properly getting the last_n if it has to span multiple chunks, as while it iterates each chunk in reverse order, chunks iterate in forward order, so the last N of the first chunk are not the last N of the entire list
There was a problem hiding this comment.
lrange = [3, 4] [1, 2] (chunks read from the end of the list)
reversed(chunk) = [4, 3] [2, 1]
result = [4, 3, 2, 1] (assuming no filtering, append as long as last_n)
reversed(results) = [1, 2, 3, 4]
There was a problem hiding this comment.
oh yeah, the start index calculation means it's starting from the end so the chunks are iterated back to front
I was pondering one of our use cases about limited reading of big lists, would be nice to be able to choose which lines to fetch
let me know if this is not a good place for this, could also be in the... project that actually needs it instead of in Minique 🤔
but this would implement it for that possible use case!