Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat RC.6 #379

Merged
merged 4 commits into from
Sep 15, 2016
Merged

Feat RC.6 #379

merged 4 commits into from
Sep 15, 2016

Conversation

adrianfaciu
Copy link

Working to update to RC.6 version of Angular. Currently work in progress.
Still need to update test (execution) and check if anything else is needed beside that.

@valorkin
Copy link
Member

valorkin commented Sep 8, 2016

PhantomJS 2.1.1 (Linux 0.0.0) ERROR Error: Missing: SyncTestZoneSpec at /home/travis/build/valor-software/ng2-file-upload/test.bundle.js:283
oO

@adrianfaciu
Copy link
Author

Yes, I've seen that. I'm working with Bash on windows and for some reason PhantomJS fails to start (there are some issues opened with this). I'll try to find a fix/workaround today.

@Martin-Luft
Copy link

I think you should change the imports (the order is important):

require('zone.js/dist/zone');
require('zone.js/dist/long-stack-trace-zone');
require('zone.js/dist/async-test');
require('zone.js/dist/fake-async-test');
require('zone.js/dist/sync-test');
require('zone.js/dist/proxy');
require('zone.js/dist/jasmine-patch');

@mktitan
Copy link

mktitan commented Sep 9, 2016

@adrianfaciu This update would be greatly appreciated. Looking forward to it.

@valorkin
Copy link
Member

valorkin commented Sep 9, 2016

Awesome! @otelnov can you check what is left? :)

@adrianfaciu
Copy link
Author

adrianfaciu commented Sep 10, 2016

@valorkin @otelnov I've fixed the test execution. Everything should be fine now.
This should fix #378

@GreenToast
Copy link

GreenToast commented Sep 14, 2016

Do you also generate *.metadata.json-files to support aot-compilation? Otherwise it would result in the similar issue like ng2-bootstrap valor-software/ngx-bootstrap#933

@valorkin
Copy link
Member

Not yet, but will be added

On Wed, Sep 14, 2016, 15:57 GreenToast notifications@github.com wrote:

Do you also generate *.metadata.json-files to support aot-compilation?
Similar issue at ng2-bootstrap valor-software/ngx-bootstrap#933
valor-software/ngx-bootstrap#933


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#379 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk4zIRI7QEXhc8dzEbRCExEW-29DTdks5qp-8sgaJpZM4J3RYx
.

@otelnov
Copy link
Contributor

otelnov commented Sep 15, 2016

@valorkin @adrianfaciu
#393

@valorkin valorkin merged commit 0e7e397 into valor-software:development Sep 15, 2016
@valorkin
Copy link
Member

@adrianfaciu @otelnov thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants