Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): add toggle opportunity for carousel-indicators #1021

Closed
artdias90 opened this issue Sep 23, 2016 · 5 comments
Closed

feat(carousel): add toggle opportunity for carousel-indicators #1021

artdias90 opened this issue Sep 23, 2016 · 5 comments

Comments

@artdias90
Copy link
Contributor

Is there a way to switch off carousel slides direct link below the slide? Would like to not show that.

@valorkin
Copy link
Member

small PR could help

  • you can add new @input() property .... (not sure about name)
  • and one *ngIf to carousel template

it should be visible by default of course, or it will be a breaking change for other users

@valorkin
Copy link
Member

BTW if you have any questions, welcome to slack

@gmenih
Copy link

gmenih commented Nov 9, 2016

@valorkin which branch should I branch off of, if I want to implement this?

@valorkin
Copy link
Member

valorkin commented Nov 9, 2016

https://github.com/valor-software/ng2-bootstrap/tree/feat-ng-cli

if possible wait until Friday, I want to finish structure refactoring and update deploying model
test it and merge to dev

@gmenih
Copy link

gmenih commented Nov 9, 2016

@valorkin yeah sure. I hide them with CSS for now, so no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants