Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No space beetween accordion groups #1854

Closed
AGrzes opened this issue Apr 1, 2017 · 1 comment · Fixed by #2014
Closed

No space beetween accordion groups #1854

AGrzes opened this issue Apr 1, 2017 · 1 comment · Fixed by #2014
Labels
comp(accordion)

Comments

@AGrzes
Copy link

AGrzes commented Apr 1, 2017

In pure bootstrap there is a space between panels in panel-group implemented by css rule

.panel-group .panel + .panel {
    margin-top: 5px;
}

But in ng2-bootstrap each panel is wrapped in accordion-group tag so the rule does not apply eliminating space between groups.

Example - good - bootstrap v3.3.7 + angular-ui-bootstrap 2.2.0 + angular 1.5.8
old

Example - bad - bootstrap v3.3.7 + ng2-bootstrap 1.6.0 + angular 2.4.9
new
@artemvfrolov
Copy link
Contributor

maybe it's fixed in #2014

@artemvfrolov artemvfrolov mentioned this issue Jun 2, 2017
Merged
valorkin pushed a commit that referenced this issue Jun 27, 2017
@artemvfrolov @valorkin
fix(acordion): space beetween accordion groups (#2014)
ad2da54 
fixes #1854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(accordion)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix (acordion) space beetween accordion groups
3 participants
@AGrzes @valorkin @artemvfrolov