Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): left sidebar is not fully visible on small screens #3383

Closed
smnbbrv opened this issue Jan 3, 2018 · 3 comments
Closed

fix(demo): left sidebar is not fully visible on small screens #3383

smnbbrv opened this issue Jan 3, 2018 · 3 comments
Assignees
@EvilAlexei
Labels
comp(demo) issue

Comments

@smnbbrv
Copy link

smnbbrv commented Jan 3, 2018 •
edited by IlyaSurmay
Loading

Bug description or feature request:

Cannot see Typeahead sidebar menu item on Mac 13 inches in Demo. The sidebar is not scrollable; at first I really thought it is not supported anymore
@1-0-1
Copy link

1-0-1 commented Jan 3, 2018

Is this about the documentation page @ https://valor-software.com/ngx-bootstrap/#/getting-started? The scrollbar is off the screen in the left hand panel and so I can't scroll to the last item in the list.

@valorkin
Copy link
Member

there are should be scroll bar
plus there are a filter on top

@1-0-1
Copy link

1-0-1 commented Jan 11, 2018

Yes, the scroll bar is there, but the sizing for the left panel is off such that the end of the scroll bar is not visible.
If you know what you are looking for, yes you can filter. But for a new user who is looking to see what there is, this doesn't work.
image

@YevheniiaMazur YevheniiaMazur changed the title Sidebar is not fully visible on small screens fix(demo): sidebar is not fully visible on small screens Jan 17, 2018
@YevheniiaMazur YevheniiaMazur changed the title fix(demo): sidebar is not fully visible on small screens fix(demo): left sidebar is not fully visible on small screens Jan 17, 2018
@YevheniiaMazur YevheniiaMazur mentioned this issue Jan 17, 2018
Closed
29 tasks
EvilAlexei pushed a commit that referenced this issue Feb 14, 2018
fix(demo): fix left sidebar is not fully visible on small screens
ca5cc6e 
- Changed buttons for bootstrap versions to prevent height changes on small screens

Closes #3383
@EvilAlexei EvilAlexei mentioned this issue Feb 14, 2018
Merged
3 tasks
@ghost ghost assigned EvilAlexei Feb 14, 2018
@ghost ghost added the in progress label Feb 14, 2018
@ghost ghost removed the in progress label Apr 5, 2018
valorkin pushed a commit that referenced this issue Apr 5, 2018
@EvilAlexei @valorkin
fix(demo): fix left sidebar is not fully visible on small screens (#3780
7e30c6f 
)

- Changed buttons for bootstrap versions to prevent height changes on small screens

Closes #3383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvilAlexei EvilAlexei

Labels
comp(demo) issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@valorkin @EvilAlexei @1-0-1 @smnbbrv @IlyaSurmay @YevheniiaMazur