Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): fix input data validation for timepicker #3549 #3288 #3588

Merged

Conversation

IraErshova
Copy link
Contributor

@IraErshova IraErshova commented Jan 30, 2018

Fix input validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close #3549 #3288

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.

@@ -50,6 +52,12 @@ export function timepickerReducer(state = initialState, action: Action) {

const _newTime = changeTime(state.value, { hour: action.payload.step });

if (state.config.max || state.config.min) {

This comment was marked as off-topic.

this.hours = hours;

const isValid = isHourInputValid(this.hours, this.isPM())

This comment was marked as off-topic.

@IraErshova IraErshova force-pushed the feat-timepicker-validation branch from a3a4cb6 to fc3c394 Compare January 31, 2018 11:05
@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #3588 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3588      +/-   ##
===============================================
+ Coverage        72.24%   72.24%   +<.01%     
===============================================
  Files              252      253       +1     
  Lines             8233     8234       +1     
  Branches          1563     1563              
===============================================
+ Hits              5948     5949       +1     
  Misses            1863     1863              
  Partials           422      422
Impacted Files Coverage Δ
src/timepicker/reducer/timepicker.store.ts 90% <100%> (-0.91%) ⬇️
src/mini-ngrx/index.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1308eae...8551b46. Read the comment docs.

@EvilAlexei EvilAlexei requested a review from valorkin January 31, 2018 12:09
@IraErshova IraErshova changed the title feat(timepicker): add validation for timepicker #3549 #3288 fix(timepicker): fix input data validation for timepicker #3549 #3288 Jan 31, 2018
IlyaSurmay
IlyaSurmay previously approved these changes Jan 31, 2018
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix imports

@@ -1,5 +1,5 @@
import { Injectable } from '@angular/core';
import { Action } from '../../mini-ngrx/index';
import { Action } from '../../mini-ngrx';

This comment was marked as off-topic.

This comment was marked as off-topic.

@YevheniiaMazur
Copy link

Needs to fix conflicting files

Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
@ghost ghost assigned valorkin Mar 13, 2018
@ghost ghost added the in progress label Mar 13, 2018
@valorkin valorkin merged commit d8ee1f8 into valor-software:development Mar 29, 2018
@ghost ghost removed the in progress label Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(timepicker): Add validation for timepicker
5 participants