fix(timepicker): fix input data validation for timepicker #3549 #3288 #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSurmay
suggested changes
Jan 30, 2018
| @@ -50,6 +52,12 @@ export function timepickerReducer(state = initialState, action: Action) { | |||
|
|
|||
| const _newTime = changeTime(state.value, { hour: action.payload.step }); | |||
|
|
|||
| if (state.config.max || state.config.min) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| this.hours = hours; | ||
|
|
||
| const isValid = isHourInputValid(this.hours, this.isPM()) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IraErshova
force-pushed
the
feat-timepicker-validation
branch
from
a3a4cb6 to
fc3c394
Compare
Codecov Report
@@ Coverage Diff @@
## development #3588 +/- ##
===============================================
+ Coverage 72.24% 72.24% +<.01%
===============================================
Files 252 253 +1
Lines 8233 8234 +1
Branches 1563 1563
===============================================
+ Hits 5948 5949 +1
Misses 1863 1863
Partials 422 422
Continue to review full report at Codecov.
|
IraErshova
changed the title
IlyaSurmay
previously approved these changes
Jan 31, 2018
valorkin
requested changes
Mar 1, 2018
| @@ -1,5 +1,5 @@ | |||
| import { Injectable } from '@angular/core'; | |||
| import { Action } from '../../mini-ngrx/index'; | |||
| import { Action } from '../../mini-ngrx'; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IraErshova
force-pushed
the
feat-timepicker-validation
branch
from
fc3c394 to
3c36269
Compare
|
Needs to fix conflicting files |
IraErshova
force-pushed
the
feat-timepicker-validation
branch
from
3c36269 to
e5ffded
Compare
Add validation for timepicker based on ui-bootstrap validation. Fix min-max validation issue. close valor-software#3549 valor-software#3288
IraErshova
force-pushed
the
feat-timepicker-validation
branch
from
e5ffded to
99ef537
Compare
ghost
assigned
valorkin
approved these changes
Mar 13, 2018
valorkin
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix input validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.
close #3549 #3288
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.