Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): for ng2 beta #38

Closed
heziqiang opened this issue Nov 30, 2015 · 5 comments
Closed

fix(datepicker): for ng2 beta #38

heziqiang opened this issue Nov 30, 2015 · 5 comments

Comments

@heziqiang
Copy link

I found DatePicker in the Directives menu, but nothing in detail.
Do you have any plan to add it, or go further, add the DateTimePicker?
@valorkin
Copy link
Member

It is there but need to be fixed

@valorkin valorkin changed the title any plan to add "DatePicker" or even "DateTimePicker" Fix: DatePicker for latest ng2 Nov 30, 2015
@valorkin valorkin changed the title Fix: DatePicker for latest ng2 fix(datepicker): for ng2 beta Jan 6, 2016
@amanwebdev
Copy link
Contributor

Anyone working on this issue? I want to take it up and also what fixes the DatePicker component needs?

@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

@amansharma0091 at least make it working :)
no one is currently working on it
I would say mental model is wrong
but as first step I will appreciate if it at least will throw any errors :)

@amanwebdev
Copy link
Contributor

I've updated the code to beta 1 and it's working. Will make a pull request soon.
Mental model is wrong? In what ways? What should be the correct model?

@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

Awesome waiting for it! :)

amanwebdev added a commit to amanwebdev/ng2-bootstrap that referenced this issue Feb 1, 2016
@amanwebdev
fix(datepicker): upgrade to beta 1, issue valor-software#38
ab9dd87
valorkin pushed a commit that referenced this issue Feb 1, 2016
@amanwebdev @valorkin
fix(datepicker): upgrade to beta 1, issue #38
bdf7d74
valorkin added a commit that referenced this issue Feb 1, 2016
@valorkin
feat(datepicker): datepicker fixed for 0-beta.2, closes #120, fixes #38
859f9c6
valorkin added a commit that referenced this issue Feb 1, 2016
@valorkin
feat(datepicker): datepicker fixed for 0-beta.2, closes #120, fixes #38
4c3bcab
valorkin pushed a commit that referenced this issue Feb 2, 2016
@amanwebdev @valorkin
fix(datepicker): upgrade to beta 1, issue #38
b1a5507
valorkin added a commit that referenced this issue Feb 2, 2016
@valorkin
feat(datepicker): datepicker fixed for 0-beta.2, closes #120, fixes #38
970010f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valorkin @amanwebdev @heziqiang