Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: does not always close by 'Esc' key #3890

Closed
ctrl-brk opened this issue Feb 28, 2018 · 0 comments
Closed

Datepicker: does not always close by 'Esc' key #3890

ctrl-brk opened this issue Feb 28, 2018 · 0 comments
Labels
comp(datepicker) needs: reproduce

Comments

@ctrl-brk
Copy link

ctrl-brk commented Feb 28, 2018 •
edited
Loading

Go to the demo page and open the first datepicker (basic example). Press 'esc' - it closes. Now open again and click on the year/month buttons. Press 'esc' - it does not close.
@5earle 5earle mentioned this issue Mar 11, 2018
Merged
5 tasks
valorkin pushed a commit that referenced this issue Dec 13, 2018
@5earle @valorkin
feat(datepicker): esc can close datepicker (#3966)
3ee6eac 
Fixes #3890
* tab can close datpicker, esc can exit datpicker

* fix(datepicker): conflicts resolve & leave only esc datepicker close

* feat(datepicker): add test
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this issue Oct 10, 2019
@5earle @leo6104
feat(datepicker): esc can close datepicker (valor-software#3966)
ecf498e 
Fixes valor-software#3890
* tab can close datpicker, esc can exit datpicker

* fix(datepicker): conflicts resolve & leave only esc datepicker close

* feat(datepicker): add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(datepicker) needs: reproduce
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctrl-brk @IlyaSurmay