Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker display 'value' not updated when same date is selected again #5209

Closed
masoomar opened this issue May 14, 2019 · 0 comments · Fixed by #5496
Closed

DatePicker display 'value' not updated when same date is selected again #5209

masoomar opened this issue May 14, 2019 · 0 comments · Fixed by #5496
Labels
comp(datepicker) enhancement

Comments

@masoomar
Copy link

Bug description or feature request:

I want to display 'Today' string instead of the date, when current date is selected.
I am using value property to display either 'Today' if current date is selected or display date if any other date is selected other than current date.

When you select current date the first time, the value in the input box updates to 'Today' which is expected. However if you re-select current date again, it doesn't display 'Today' but instead just displays the date. Please see the StackBlitz example below to reproduce the issue.

Expected:
Datepicker input should update value when same date is selected again.

Plunker/StackBlitz that reproduces the issue:

Using Plunkr, StackBlitz is the best way to show your issue. Issues without link to an example of reproduction might be closed.

You can use one of starter templates:

StackBlitz: https://stackblitz.com/edit/ngx-bootstrap-datepicker-mbae2d?file=app%2Fapp.component.ts

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap:

Angular: 5

Bootstrap: 3.3.7

Build system: Angular CLI, System.js, webpack, starter seed:
@max-arias max-arias removed their assignment Oct 8, 2019
castriganoj added a commit to castriganoj/ngx-bootstrap that referenced this issue Oct 14, 2019
@castriganoj
fix(datepicker): Maintain selected date when same date selected (valo…
31309ea 
…r-software#5209)

Use getTime() for JS dateTime compare.
@castriganoj castriganoj mentioned this issue Oct 17, 2019
Merged
5 tasks
daniloff200 added a commit that referenced this issue Jan 11, 2020
@castriganoj @Domainv @daniloff200
fix(datepicker): Maintain selected date when same date selected (#5209)…
b674b4b 
… (#5496)

fix(datepicker): Maintain selected date when same date selected  (#5209) (#5496)
Co-authored-by: Vitaliy Makogon <mvitaliyd@gmail.com>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 20, 2020
@castriganoj @Domainv
@daniloff200 @IraErshova
fix(datepicker): Maintain selected date when same date selected (valo…
dba01db 
…r-software#5209) (valor-software#5496)

fix(datepicker): Maintain selected date when same date selected  (valor-software#5209) (valor-software#5496)
Co-authored-by: Vitaliy Makogon <mvitaliyd@gmail.com>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(datepicker) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datepicker): Maintain selected date when same date selected (#5209) castriganoj/ngx-bootstrap
4 participants
@max-arias @masoomar @daniloff200 @ludmilanesvitiy