Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why ukLocale was removed from chronos? #5351

Closed
pbaukov opened this issue Aug 5, 2019 · 2 comments · Fixed by #5396
Closed

Why ukLocale was removed from chronos? #5351

pbaukov opened this issue Aug 5, 2019 · 2 comments · Fixed by #5396
Labels
comp(datepicker) feat(chronos) feat-request in progress

Comments

@pbaukov
Copy link

pbaukov commented Aug 5, 2019

Hello there, I'm developer from Ukraine and I'm wondering why Ukrainian locale was removed? I see it was there like 1-1.5 years ago and now it's gone. How can I add my own locale to datepicker then?
@pbaukov
Copy link
Author

pbaukov commented Aug 6, 2019 •
edited
Loading

OK, as I see, it's just not added here
https://github.com/valor-software/ngx-bootstrap/blob/development/src/locale.ts

Is there any reason for that?

@ludmilanesvitiy
Copy link
Contributor

@pbaukov If you need a new locale - you can create a PR with that change.

ludmilanesvitiy pushed a commit that referenced this issue Sep 19, 2019
feat(chronos): add uk locale resolve #5351
912a7b1
@ludmilanesvitiy ludmilanesvitiy mentioned this issue Sep 19, 2019
Merged
5 tasks
Domainv pushed a commit that referenced this issue Oct 1, 2019
@ludmilanesvitiy @Domainv
feat(chronos): add uk locale resolve #5351 (#5396)
f2187ea
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 20, 2020
@ludmilanesvitiy @IraErshova
feat(chronos): add uk locale resolve valor-software#5351 (valor-softw…
1002271 
…are#5396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(datepicker) feat(chronos) feat-request in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(chronos): add uk locale resolve #5351 valor-software/ngx-bootstrap
3 participants
@pbaukov @daniloff200 @ludmilanesvitiy