fix(datepicker): Maintain selected date when same date selected (#5209)

[castriganoj]

Use getTime() for JS dateTime compare.

closes #5209

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

• read and followed the CONTRIBUTING.md guide.
• built and tested the changes locally.
• added/updated tests.
• added/updated API documentation.
• added/updated demos.

[castriganoj]

This does not exactly solve what the issue requests. Based on what was found in code and what the issue requests this update does solve the requester's issue of maintaining the 'today' string. When the Date value is set in the bs-datepickerDirective component there is a check for the same value. I believe the intention was to check if the same date was selected and return immediately if so. Otherwise continue and propagate the change to the other components with this.bsValueChange.emit(value). It compares 2 date objects which would always return false even if they are the same date.

To summarize, this change may solve a separate but overlapping issue. Custom text inputs would require separate and additional changes. I look forward to your feedback. Please let me know how to proceed.

Thanks much, Jim.

[codecov]

Codecov Report

Merging #5496 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #5496   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3078f07...1f75549. Read the comment docs.

[daniloff200]

I think, it can be useful.

[daniloff200]

hey, @castriganoj
Thanks again for your contribution ! Could you please fill out this form so we can send some swag to you? Thanks!