Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker - readonlyInput option #759

Closed
antitoine opened this issue Jul 20, 2016 · 3 comments · Fixed by #768
Closed

TimePicker - readonlyInput option #759

antitoine opened this issue Jul 20, 2016 · 3 comments · Fixed by #768

Comments

@antitoine
Copy link

Hi,

I wonder if it would be possible to make the option readonlyInput more efficient in the TimePicker component. The display style is correctly apply, but we can continue to change value in the input.

Thank

@valorkin
Copy link
Member

hm, why would you render whole timepicker in readonly mode

@antitoine
Copy link
Author

this makes sense with the option, right?

readonlyInput (?boolean=false) - if true hours and minutes fields will be readonly

For me, this option is like put the "disabled" attribute in every input

@adrianfaciu
Copy link

What would be the desired behavior here ? I would say, if read only, hide the arrows. But one could just want them there but not clickable (which would be worse from UX point of view, but would maintain the same height all the time for example). AM/PM toggle should also be affected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants