Issue 766 #1025
Merged
Issue 766 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class names to the outputted nav-items
Current coverage is 90.40% (diff: 100%)
@@ development #1025 diff @@
=============================================
Files 26 26
Lines 781 782 +1
Methods 142 142
Messages 0 0
Branches 115 115
=============================================
+ Hits 706 707 +1
Misses 75 75
Partials 0 0
|
|
Looks good to me! @otelnov is working on AoT for ng2-bootstrap, it is almost done. Let us wait a bit and then merge this on top |
…ion (tested in Chrome). This will probably fix issue #842 which sounds exactly like the scenario this fixes for me.
|
In testing this I hit upon the exact same situation as issue #842 This latest commit solves it for me. The problem was highly repeatable and had me stumped for a little while. Rather than use the $event.preventDefault I just set the href to void, not sure which is better / preferred. |
|
It's great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had need to pull right a tab, this PR allows us to specify a customClass to include into the nav-item element's class attribute. This should also resolve issue #766