Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tooltip): added Tooltip delay functionality #1116

Merged
merged 3 commits into from
Oct 13, 2016
Merged

feat(tooltip): added Tooltip delay functionality #1116

merged 3 commits into from
Oct 13, 2016

Conversation

Serginho
Copy link
Contributor

I need this functionality, so I decided to implement it.

TsLint is ok.
Docs are updated.

If I forgot something, just tell me.

@codecov-io
Copy link

codecov-io commented Oct 12, 2016 •
edited
Loading

Current coverage is 85.62% (diff: 100%)

Merging #1116 into development will not change coverage

@@           development      #1116   diff @@
=============================================
  Files               35         35          
  Lines             1280       1280          
  Methods            228        228          
  Messages             0          0          
  Branches           213        213          
=============================================
  Hits              1096       1096          
  Misses             184        184          
  Partials             0          0

Powered by Codecov. Last update ec6ccc3...3f0271a

@valorkin
Copy link
Member

Except 2 small changes looks great to me 👍

@valorkin valorkin self-assigned this Oct 13, 2016
@valorkin valorkin changed the title Added Tooltip delay functionality feat(tooltip): added Tooltip delay functionality Oct 13, 2016
@Serginho
Copy link
Contributor Author

Do you want me to change anything else?

valorkin
valorkin requested changes Oct 13, 2016
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this 3 small things

components/tooltip/tooltip.directive.ts

this.triggerStateChanged();
this.delayTimeoutId = setTimeout(() => {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

components/tooltip/tooltip.directive.ts
}

// params event, target
@HostListener('focusout')
@HostListener('mouseleave')
public hide():void {
if (this.delayTimeoutId) {
clearTimeout(this.delayTimeoutId);

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

components/tooltip/tooltip.directive.ts
@@ -33,6 +34,8 @@ export class TooltipDirective {
private visible:boolean = false;
private tooltip:ComponentRef<any>;

private delayTimeoutId:NodeJS.Timer;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@valorkin
Copy link
Member

@Serginho oh, sorry I did not saw this submit review thing before

valorkin
valorkin approved these changes Oct 13, 2016
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much

@valorkin valorkin merged commit eb90e9a into valor-software:development Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees

@valorkin valorkin

Labels
comp(tooltip)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serginho @codecov-io @valorkin