feat(sortable): module #1295

Le0Michine · 2016-12-05T20:45:32Z

This PR contains implementation of d&d sortable list, at the moment it supports:

ngModel
drag&drop between different instances of the component
styles for container, items, active item
items list could be either string[] or object[] (fieldName should be provided in that case)
animation of item insertion/removing

Unfortunately I haven't found any information about contribution rules, if it is necessary to create some demo etc. please notify me

codecov-io · 2016-12-05T20:50:34Z

Current coverage is 85.43% (diff: 100%)

Merging #1295 into development will increase coverage by 0.74%

@@           development      #1295   diff @@
=============================================
  Files               76         80     +4   
  Lines             2142       2252   +110   
  Methods             20         21     +1   
  Messages             0          0          
  Branches           285        293     +8   
=============================================
+ Hits              1814       1924   +110   
  Misses             230        230          
  Partials            98         98

Powered by Codecov. Last update 6788f17...cae3a62

valorkin · 2016-12-06T10:22:02Z

Awesome!
Can you please rename to simply sortable?

valorkin

Looks good to me!
Please apply mentioned changes, tests and doc

src/index.ts

@@ -20,7 +21,7 @@ import { ComponentsHelper } from './utils/components-helper.service';
 @NgModule({
 exports: [
 AccordionModule, AlertModule, ButtonsModule, CarouselModule, CollapseModule, DatepickerModule, DropdownModule,
- ModalModule, PaginationModule, ProgressbarModule, RatingModule, TabsModule, TimepickerModule, TooltipModule,
+ ModalModule, PaginationModule, ProgressbarModule, RatingModule, SortableListModule, TabsModule, TimepickerModule, TooltipModule,


src/sortable-list/index.ts

@@ -0,0 +1 @@
+export * from './sortable-list.module';


src/sortable-list/components/sortable-list.component.ts

+/* tslint:disable */
+@Component({
+ selector: 'ng2-sortable-list',
+ templateUrl: './sortable-list.component.html',


export everything from sortable module

fixed lint warning added basic tests

implemented tests for service

Le0Michine · 2016-12-07T19:47:28Z

@valorkin, I have added docs and tests
but there is a problem with build and I don't think that it is because of my commit, could you take a look?

…trap into development

Le0Michine · 2016-12-08T21:57:18Z

@valorkin I fixed tests with pagination module (set _page = 1 by default, it was undefined by default in tests and noPrevious() method returned false because of it), so now it seems there is no blocker from CI side.
Fix in last commit 92ea666, unfortunately it has wrong comment

valorkin · 2016-12-08T23:47:40Z

This is huge!!! Let me get to this
@SergeyKuryatnick check this out

Le0Michine · 2016-12-15T17:58:17Z

@valorkin ping, just to remind :)

valorkin · 2016-12-15T20:24:06Z

hey, I remember it! ;)
check new structure of src folder and how it is now published
https://unpkg.com/ng2-bootstrap@1.1.16-4/

almost ready to more not core bootstrap modules

actually docs left...
and publish new small version Release v1.1.17 #1328

fixed compatibility with ie11

valorkin · 2016-12-21T23:22:31Z

This is huge!

valorkin · 2016-12-26T15:06:04Z

I am actually ready to merge...
;)
drop me a note in https://ngx-slack.herokuapp.com/
and we will go through it

Le0Michine added 2 commits December 5, 2016 21:28

Added sortable-list module

eddede5

added sortable-list module into the main module

75b634f

valorkin changed the title ~~Added sortable-list module~~ feat(sortable-list): module Dec 6, 2016

valorkin added needs review needs: tests labels Dec 6, 2016

valorkin reviewed Dec 6, 2016

View reviewed changes

Le0Michine added 11 commits December 6, 2016 15:28

renamed sortable-list to sortable

0dca2b1

removed sortable module from root index.ts

b20bb27

export everything from sortable module

inlined html template

5a6553b

created docs page for sortable component

6d08383

removed console.log

556d97b

fixed lint warning added basic tests

added tests for reordering

9db1056

added tests for onZoneDragover method

7eb8e4e

added test for insert item from another container

2edce40

fixed quotes

65f479f

fixed insertion test

40377ff

finished component covering

0287049

implemented tests for service

Le0Michine changed the title ~~feat(sortable-list): module~~ feat(sortable): module Dec 7, 2016

Le0Michine added 3 commits December 8, 2016 12:57

Merge remote-tracking branch 'upstream/development' into development

ca95219

Merge remote-tracking branch 'upstream/development' into development

2dfd04f

Merge branch 'development' of https://github.com/Le0Michine/ng2-boots…

92ea666

…trap into development

Le0Michine added 2 commits December 18, 2016 11:42

changed dirs structure

b1abbdf

fixed compatibility with ie11

use dumb object instead of Event

3d37cee

Le0Michine added 4 commits December 30, 2016 13:10

Merge remote-tracking branch 'upstream/development' into development

5b8ed5a

updated docs

6efb630

update docs (added doc comments)

c469581

fixed compatibility with firefox

cae3a62

valorkin merged commit fab3df5 into valor-software:development Jan 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sortable): module #1295

feat(sortable): module #1295

Le0Michine commented Dec 5, 2016 •

edited

Loading

codecov-io commented Dec 5, 2016 •

edited

Loading

valorkin commented Dec 6, 2016

valorkin left a comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Le0Michine commented Dec 7, 2016 •

edited

Loading

Le0Michine commented Dec 8, 2016 •

edited

Loading

valorkin commented Dec 8, 2016

Le0Michine commented Dec 15, 2016

valorkin commented Dec 15, 2016

valorkin commented Dec 21, 2016

valorkin commented Dec 26, 2016

feat(sortable): module #1295

feat(sortable): module #1295

Conversation

Le0Michine commented Dec 5, 2016 • edited Loading

codecov-io commented Dec 5, 2016 • edited Loading

Current coverage is 85.43% (diff: 100%)

valorkin commented Dec 6, 2016

valorkin left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Le0Michine commented Dec 7, 2016 • edited Loading

Le0Michine commented Dec 8, 2016 • edited Loading

valorkin commented Dec 8, 2016

Le0Michine commented Dec 15, 2016

valorkin commented Dec 15, 2016

valorkin commented Dec 21, 2016

valorkin commented Dec 26, 2016

Le0Michine commented Dec 5, 2016 •

edited

Loading

codecov-io commented Dec 5, 2016 •

edited

Loading

Le0Michine commented Dec 7, 2016 •

edited

Loading

Le0Michine commented Dec 8, 2016 •

edited

Loading