Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play carousel on mouseup #1433

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Conversation

felixkubli
Copy link
Contributor

(mouseleave) can't be used on a mobile devise, so a (mouseup) should be added.

@valorkin
Copy link
Member

valorkin commented Jan 3, 2017

@felixkubli can you please rebase on latest dev?

@codecov-io
Copy link

Current coverage is 84.57% (diff: 100%)

Merging #1433 into development will not change coverage

@@           development      #1433   diff @@
=============================================
  Files               76         76          
  Lines             2146       2146          
  Methods             20         20          
  Messages             0          0          
  Branches           287        287          
=============================================
  Hits              1815       1815          
  Misses             231        231          
  Partials           100        100          

Powered by Codecov. Last update 8c59839...2aacca8

@felixkubli
Copy link
Contributor Author

@valorkin rebase is done.

@valorkin
Copy link
Member

valorkin commented Jan 4, 2017

awesome, thanks
seems I will have to revisit it again, (https://github.com/twbs/bootstrap/blob/v4-dev/js/src/carousel.js#L232-L237)
but should work for now

@valorkin valorkin merged commit a1d7983 into valor-software:development Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants