Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #124: dropdown outside #166

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Fix #124: dropdown outside #166

merged 1 commit into from
Feb 10, 2016

Conversation

rluba
Copy link
Contributor

@rluba rluba commented Feb 10, 2016

This fixes #124 by

  • ensuring that dropdown.menuEl is set
  • improving the "clicked element is inside menu" test

@valorkin
Copy link
Member

Thanks for your time!
2 notes:

Thanks in advance

@rluba
Copy link
Contributor Author

rluba commented Feb 10, 2016

Sure, will do!

@rluba
Copy link
Contributor Author

rluba commented Feb 10, 2016

@valorkin: Better?

@rluba
fix: "outsideClick" still closed the dropdown on any click
6348f72 
- Implement a `DropdownMenu` directive to fix "always undefined directive.menuEl"
- Test for "OUTSIDECLICK" should not consider menu children to be outside the menu

This fixes valor-software#124
@valorkin
Copy link
Member

awesome
it should be fix(dropdown) except that all awesome, I will merge when test are done anyway

valorkin added a commit that referenced this pull request Feb 10, 2016
@valorkin
Merge pull request #166 from rluba/fix/#124_dropdown_outside
03df5a4 
Fix #124: dropdown outside
@valorkin valorkin merged commit 03df5a4 into valor-software:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rluba @valorkin