Implement the canonical isOpenChange event to allow two-way binding on isOpen
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, same as with fix for #124 |
- Implement the canonical `isOpenChange` event to allow two-way binding - Update documentation example to use the new two-way binding This allows bindings like `<… dropdown [(isOpen)]="my.isOpen">` to prevent the internal and external flags from going out-of-sync whenever the dropdown is closed automatically. From the angular2 documentation: > […] Angular matches [(x)] to an x input property for property binding and an xChange output property for event binding.
rluba
force-pushed
the
feature/isOpen_two_way_binding
branch
from
e7ab684 to
674fcb7
Compare
|
Here you go. I’ve also updated the documentation |
valorkin
added a commit
that referenced
this pull request
Feb 10, 2016
Implement the canonical `isOpenChange` event to allow two-way binding on `isOpen`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows two-way bindings like
<… dropdown [(isOpen)]="my.isOpen">to prevent the internal and external flags from going out-of-sync whenever the dropdown is closed automatically.From the angular2 documentation:
This is a full replacement for the
onToggleevent but you might want to keep it around for backwards compatibility reasons.