Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdowns): dropdown should close correctly when used in modals (fixes #267, fixes #221) #280

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

mkjeff
Copy link
Contributor

@mkjeff mkjeff commented Mar 14, 2016

fixed Dropdown does not work on angular2-modal #267
fixed dropdown button auto closes #221
changed ButtonRadio.btnRadio to be able to hold any object

@valorkin
Copy link
Member

I believe it should work for ng2-modal
let me see, what can be done
may be modal component should be changed

@valorkin
Copy link
Member

@mkjeff ok, now looks even better

  1. leave here only dropdown fixes
    buttons will be updated when this will be fixed: Angular 2 template driven form radio button not working angular/angular#7642
  2. could you please squash commits while rebasing on top of master? :)
    and name it
    fix(dropdowns): dropdown should close correctly when used in modals (fixes #267, fixes #221)

When done, drop a note here, so I will test and merge it ASAP
Thanks in advance :)

@mkjeff mkjeff changed the title fixed some bugs for Dropdown and ButtonRadio fix(dropdowns): dropdown should close correctly when used in modals (fixes #267, fixes #221) Mar 25, 2016
@mkjeff
Copy link
Contributor Author

mkjeff commented Mar 25, 2016

@valorkin had sorted out my commits

@valorkin
Copy link
Member

Awesome! Merging

@valorkin valorkin merged commit 6c1358e into valor-software:master Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants