fix(old-datepicker): summer time

[mdfonseca]

Datepicker repeat days (ex:. 15-oct-2017) when using Safari (Mac) and lang pt-BR for summer time

Problem: Opening the datepicker on Safari in a month with summer time (ex:. 2017-oct-15 - lang: pt-BR) generates a calendar containing days 1,2,3,..,14, 15, 15, 15, 15,..., 15

Context: Safari "new Date(2017, 9, 15)" for lang pt-BR generates a date like "14 oct 2017 23:00:00", then the component "daypicker.component.ts" calls "fixTimeZone()" to fix that to "15 oct 2017" but that "fixed date" is not used to get the next day, which generates a loop of tha same day in theses cases of summer time.

Fix: Used the "fixed date" while generating/selecting days for the calendar

[codecov]

Codecov Report

Merging #3122 into development will decrease coverage by 0.03%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           development    #3122      +/-   ##
===============================================
- Coverage        65.31%   65.28%   -0.04%     
===============================================
  Files              209      209              
  Lines             5628     5631       +3     
  Branches           990      990              
===============================================
  Hits              3676     3676              
- Misses            1689     1692       +3     
  Partials           263      263

Impacted Files	Coverage Δ
src/datepicker/daypicker.component.ts	13.63% <ø> (ø)	⬆️
src/datepicker/datepicker-inner.component.ts	27.48% <0%> (-0.5%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080d89a...ec66c9e. Read the comment docs.

[valorkin]

@mdfonseca thanks for your help!
could you please check new datepicker?
does it have such issue?

[valorkin]

http://ngx-bootstrap.surge.sh/#/datepicker

[YevheniiaMazur]

@mdfonseca Could you provide more information about this issue, please (for example, create plunker sample, that reproduces this issue)? I couldn't reproduce it for Safari 11.0.1 - MacOS 10.12.06
I used locale pt(br) for MacOS for old datepicker, created start date as new Date(2017, 9, 15), also added button for calling fixTimeZone manually.

I need this info for better understanding, what and how should I check in this pr.

Thank you in advance

[mdfonseca]

https://valor-software.com/ngx-bootstrap/#/datepicker -> "Old" tab

New datepicker seems ok

[YevheniiaMazur]

Tested, looks good

[valorkin]

@mdfonseca can't reproduce, but I trust you :)
thanks for your time!

[valorkin]

if all will go by plan beta.11 will go out this Thursday - Friday