Fix tooltip after upgrade to angular2 2.0.0-beta.12 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierceulemans
force-pushed
the
master
branch
from
3bb0a01
to
87a57f5
Compare
|
Looks really good! |
|
all good, but tooltip at |
|
target element (tooltip container, first child) width is jumping +- 1px |
| @@ -10,7 +11,6 @@ import {TooltipOptions} from './tooltip-options.class'; | |||
|
|
|||
| @Component({ | |||
| selector: 'tooltip-container', | |||
| directives: [NgClass, NgStyle], | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
valorkin
added a commit
that referenced
this pull request
Mar 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a PR to fix the issues with tooltip that appeared with the upgrade to angular2 2.0.0-beta.12.
It also fix the change detection errors (issue #296) when running in non production mode.
Best regards,