Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): change run cypress tests for faster local run. Refactor test for making them readable #3742

Merged
merged 4 commits into from
Mar 29, 2018

Conversation

YevheniiaMazur
Copy link

@YevheniiaMazur YevheniiaMazur commented Feb 9, 2018

  • edit e2e cypress tests for making them much readable and easier to use
  • create tests examples and page objects for all demo pages
  • move all e2e tests from separate file to one (due to cypress issue)
  • change cypress config for run test using ng serve run instead of npm run demo.serve
  • fix e2e tests due to demo changes
  • add wait-on module for dynamic waiting for server boot, update cypress version to latest + update package-lock.json due to these changes
  • update travis.yaml for dynamic waiting for server boot

@ghost ghost assigned YevheniiaMazur Feb 9, 2018
@ghost ghost added the in progress label Feb 9, 2018
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #3742 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3742      +/-   ##
===============================================
- Coverage        72.23%   72.21%   -0.03%     
===============================================
  Files              252      252              
  Lines             8237     8237              
  Branches          1565     1565              
===============================================
- Hits              5950     5948       -2     
- Misses            1866     1867       +1     
- Partials           421      422       +1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a384d9...570230c. Read the comment docs.

@YevheniiaMazur YevheniiaMazur force-pushed the test-cypress-demo branch 5 times, most recently from 22040a9 to 4ff7a79 Compare February 13, 2018 15:22
@YevheniiaMazur YevheniiaMazur force-pushed the test-cypress-demo branch 2 times, most recently from 537a7cd to b5f46bc Compare February 14, 2018 16:16
@YevheniiaMazur YevheniiaMazur changed the title WIP fix(tests): change run cypress tests for faster local run fix(tests): change run cypress tests for faster local run. Feb 14, 2018
@ghost ghost added the in progress label Feb 21, 2018
@ghost ghost added the in progress label Feb 22, 2018
@YevheniiaMazur YevheniiaMazur force-pushed the test-cypress-demo branch 4 times, most recently from de3f427 to 996929a Compare February 23, 2018 14:20
@YevheniiaMazur YevheniiaMazur changed the title fix(tests): change run cypress tests for faster local run. WIP fix(tests): change run cypress tests for faster local run. Refactor test for making them readable Feb 23, 2018
@ghost ghost added the in progress label Mar 15, 2018
@YevheniiaMazur YevheniiaMazur force-pushed the test-cypress-demo branch 4 times, most recently from 754caef to ed3a7f3 Compare March 15, 2018 13:36
@YevheniiaMazur YevheniiaMazur changed the title WIP fix(tests): change run cypress tests for faster local run. Refactor test for making them readable fix(tests): change run cypress tests for faster local run. Refactor test for making them readable Mar 15, 2018
@ghost ghost added the in progress label Mar 20, 2018
@ghost ghost added the in progress label Mar 23, 2018
@valorkin valorkin merged commit c7b91fa into development Mar 29, 2018
@valorkin valorkin deleted the test-cypress-demo branch March 29, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants