Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(popover): clarify Dynamic Content demo #3836

Merged
merged 1 commit into from
Feb 22, 2018
Merged

docs(popover): clarify Dynamic Content demo #3836

merged 1 commit into from
Feb 22, 2018

Conversation

tarusin
Copy link
Contributor

@tarusin tarusin commented Feb 19, 2018

Separate options in description. The current demo has a description only for TemplateRef binding. I've split this demo into two demos and added description for Simple binding.

Closes #3834

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

IlyaSurmay
IlyaSurmay previously approved these changes Feb 19, 2018
@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #3836 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3836      +/-   ##
===============================================
- Coverage        72.03%   71.99%   -0.04%     
===============================================
  Files              252      252              
  Lines             8159     8159              
  Branches          1552     1552              
===============================================
- Hits              5877     5874       -3     
- Misses            1859     1860       +1     
- Partials           423      425       +2
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc10da...60dc178. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin
Copy link
Member

please split in 2 demos

Separate options in description
Closes #3834
@valorkin valorkin merged commit be63349 into valor-software:development Feb 22, 2018
@ghost ghost removed the in progress label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants