Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): datepicker and daterangepicker allow to select a day from other months #4568

Conversation

mc-suchecki
Copy link

fixes #4485

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Aug 23, 2018
@mc-suchecki
Copy link
Author

mc-suchecki commented Aug 23, 2018

@Domainv @valorkin can you give me some feedback on this? I think I should hide this feature behind a flag in Datepicker config, do you agree? Do you have some name suggestions?

I'll add unit tests, docs and examples after the rest of the code is accepted. :)

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #4568 into development will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4568      +/-   ##
===============================================
+ Coverage        71.42%   71.44%   +0.02%     
===============================================
  Files              259      259              
  Lines             8378     8378              
  Branches          1562     1562              
===============================================
+ Hits              5984     5986       +2     
+ Misses            1988     1985       -3     
- Partials           406      407       +1
Impacted Files Coverage Δ
...ker/themes/bs/bs-datepicker-container.component.ts 38.7% <0%> (ø) ⬆️
...hemes/bs/bs-daterangepicker-container.component.ts 30.76% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️
src/chronos/i18n/pl.ts 77.77% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d9656...d1fc374. Read the comment docs.

@mc-suchecki
Copy link
Author

@Domainv @valorkin can I get some feedback on this?

@mc-suchecki
Copy link
Author

@Domainv @valorkin could you please take a look at this PR? I would like to know if you are interested in implementing this. If so, please suggest the next steps for me. Should there be a toggle to switch this feature on/off? What should be the default setting?

@valorkin
Copy link
Member

Thanks for a PR, was fixed in other PR, and already available in v3.1.3
https://valor-software.com/ngx-bootstrap/#/datepicker#select-dates-from-other-month

@valorkin valorkin closed this Dec 16, 2018
@ghost ghost removed the needs review label Dec 16, 2018
@valorkin
Copy link
Member

PR was by @daniloff200 but I don't recall PR number

@daniloff200
Copy link
Contributor

That's it :) #4828

@valorkin
Copy link
Member

Thanks

@mc-suchecki mc-suchecki deleted the datepicker-select-day-from-other-month branch December 20, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker: allow selection for days from adjacent months.
3 participants