Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): added use-cases for pagination component #4684

Conversation

OlegDubrovskyi
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #4684 into development will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4684      +/-   ##
===============================================
+ Coverage        74.31%   74.35%   +0.04%     
===============================================
  Files              202      202              
  Lines             7102     7102              
  Branches          1447     1447              
===============================================
+ Hits              5278     5281       +3     
+ Misses            1427     1426       -1     
+ Partials           397      395       -2
Impacted Files Coverage Δ
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️
src/chronos/units/week-year.ts 93.93% <0%> (+1.51%) ⬆️
src/chronos/i18n/pl.ts 77.77% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cc974...c058a40. Read the comment docs.


**Scope**: Ngx-bootstrap DEMO / BS version 3&4

**Goal**: Show user basic functionality

This comment was marked as off-topic.

3. By default 1st page is active, and previous button is disabled
4. When user clicks on 3rd page, then next button is enabled, previous button is disabled, 1st page is inactive
and 3rd is active
5. After click on 2nd page, previous and next button are enabled, 2ng page is active, 3rd page is inactive

This comment was marked as off-topic.

----------------------

1. User opens Pagination demo page
2. User clicks on Boundary links event sub-menu

This comment was marked as off-topic.

1. User opens Pagination demo page
2. User clicks on Boundary links event sub-menu
3. By default 'First' and 'Previous' buttons are disabled, and 1st page is active
4. After click on 'Last' button, 6th page is active, 1st page is inactive, 'Next' and 'Last' buttons are disabled,

This comment was marked as off-topic.

4. When user clicks on "Toggle centering current page link" button
5. And after that user clicks on "Next" button and number of active page link less than center, numbers of page should change on next 5 pagination pages
6. When user clicks on "Toggle centering current page link" buttoner click on "Previous" button and number of active page link more than center,
numbers of page should change on previous 5 pagination pages

This comment was marked as off-topic.

2. User clicks on "Limits" sub-menu
3. By default maximum page numbers equal to 5.
4. When user clicks on "Next" button and and number of active page link more than center, numbers of page should change
5. When user clicks on "Previous" button and and number of active page link less than center, numbers of page should change

This comment was marked as off-topic.

This comment was marked as off-topic.


1. User opens "Pagination" demo page
2. User clicks on "Limits" sub-menu
3. By default maximum page numbers equal to 5.

This comment was marked as off-topic.

@OlegDubrovskyi OlegDubrovskyi force-pushed the feat-docs-use-cases-pagination branch from c8937a5 to 1875099 Compare October 12, 2018 15:37
@ghost ghost added needs review and removed needs fix labels Oct 12, 2018
@ghost ghost added the needs review label Oct 15, 2018
1. User opens Pagination demo page
2. User clicks on Basic sub-menu
3. By default 1st page is active, and previous button is disabled
4. When user clicks on 3rd page, then next button is enabled, previous button is disabled, 1st page is inactive

This comment was marked as off-topic.

3. By default 1st page is active, and previous button is disabled
4. When user clicks on 3rd page, then next button is enabled, previous button is disabled, 1st page is inactive
and 3rd is active
5. After click on 2d page, previous and next button are enabled, 2g page is active, 3rd page is inactive

This comment was marked as off-topic.

2. User clicks on "Centering the active page link" sub-menu
3. By default maximum page numbers equal to 5 and active page 1.
4. By default centering the active page link is enabled
5. When user clicks on 5th page, then active page should 5 and should by center, maximum count of pages should 5

This comment was marked as off-topic.

This comment was marked as off-topic.

1. User opens "Pagination" demo page
2. User clicks on "Content switching" sub-menu
3. After click on "Next" button, pagination content should be changed
4. After click on "Previous" button, pagination content should be changed

This comment was marked as off-topic.


1. User opens "Pagination" demo page
2. User clicks on "Custom links content" sub-menu
3. Links should be instead Previous, Next, Last, First text

This comment was marked as off-topic.

1. User opens "Pagination" demo page
2. User clicks on "Limits" sub-menu
3. By default maximum page numbers equal to 5 and active page: "1"
4. When user clicks on 5th page, then active page should 5 and should by center, maximum count of pages should 5

This comment was marked as off-topic.

This comment was marked as off-topic.

@OlegDubrovskyi OlegDubrovskyi force-pushed the feat-docs-use-cases-pagination branch 2 times, most recently from 7de3a2b to 75dfc7f Compare October 16, 2018 08:38

**Scope**: Ngx-bootstrap DEMO / BS version 3&4

**Goal**: Show user custom links content functionality

This comment was marked as off-topic.

Variations:
----------

2*. User scrolls to 'Basic'

This comment was marked as off-topic.

@@ -55,6 +55,30 @@

## Pagination

[Examples. Basic](pagination/pagination.examples.basic.use-case.md)

This comment was marked as off-topic.

Variations:
----------

2*. User scrolls to 'Pager'

This comment was marked as off-topic.

Variations:
----------

2*. User scrolls to 'Pages count changed event'

This comment was marked as off-topic.

@OlegDubrovskyi OlegDubrovskyi force-pushed the feat-docs-use-cases-pagination branch from 75dfc7f to c058a40 Compare October 25, 2018 12:08
@ghost ghost added needs review and removed needs fix labels Oct 25, 2018
@valorkin valorkin merged commit f67c76e into valor-software:development Oct 26, 2018
@ghost ghost removed the ready for merge label Oct 26, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants