Upgrade ng2-bootstrap to rc.1 #481

ciriarte · 2016-05-03T18:15:02Z

Hi Guys, I've upgraded to ~~rc.0~~ rc.1, please let me know if it looks OK to you. These changes overlap with #472 but also include the new "@angular/*" references.

components/typeahead/typeahead-container.component.ts

@@ -25,7 +25,7 @@ const TEMPLATE:any = {
      style="display: block"
      [ngStyle]="{top: top, left: left, display: display}"
      (mouseleave)="focusLost()">
-    <li *ngFor="#match of matches"
+    <li *ngFor=let match of matches"


hhsadiq · 2016-05-04T07:28:06Z

We need the upgrade to rc0 urgently. There are many breaking changes and previous version of ng2-bootstrap is not supporting rc0..Thanks alot

coutin · 2016-05-04T12:41:47Z

You could probably push to Rc1 :-)

Thx for the job done.

ciriarte · 2016-05-04T13:24:04Z

@coutin working on that!

laurelnaiad · 2016-05-05T14:27:24Z

It's somewhat troubling and now a major blocker that ng2-bootstrap is still on beta 15. What can we in the peanut gallery do to get it up to date? Is there any feedback the maintainers could provide on this PR that would help us make it happen? I'm sure there are quite a few of us who would be willing to help with whatever is holding it up. Cheers!

ciriarte · 2016-05-06T17:40:56Z

@valorkin sorry to bother you, any chance you can help us with this PR?

rodolfocop · 2016-05-06T18:05:28Z

I am willing to help in any need. I need and that this library is in RC.1 version

valorkin · 2016-05-06T19:09:20Z

Hey guys, sorry for being absent, I am at ngconf now.

valorkin · 2016-05-06T19:11:36Z

Huge thanks for your help! Let me try locally, if all good I will publish it in a sec!

laurelnaiad · 2016-05-06T19:13:15Z

I've pushed a slightly modified version of @ciriarte's PR with the built files included to my github fork so that the branch can be used from npm (and jspm).

https://github.com/laurelnaiad/ng2-bootstrap/tree/rc0-compat-temp

Basically, I just backed off of rc.1 in favor of rc.0, since I don't think there's a compelling reason to force use of rc.1, and I tweaked some other dependencies, but the main feature is that it has the built files in the branch.

hongbo-miao · 2016-05-06T19:20:45Z

@valorkin glad to see you are back to ng2-bootstrap!

laurelnaiad · 2016-05-06T19:21:06Z

Happy to see we cross-posted. :)

valorkin · 2016-05-06T19:32:05Z

@hongbo-miao sorry, I will miss a couple of days more
but when I will get back from ng-conf
things go faster :)

rodolfocop · 2016-05-06T19:44:57Z

@valorkin thanks man for attention, I can now use the ng2-file-upload with ng2-bootstrap

theunreal · 2016-05-06T20:12:21Z

Is it just me, or you get the following errors with this merge?

node_modules/ng2-bootstrap/components/alert/alert.component.ts(25,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<AlertComponent>'.
  Type '{}' is not assignable to type 'AlertComponent'.
    Property 'type' is missing in type '{}'.
node_modules/ng2-bootstrap/components/common.d.ts(1,34): error TS2307: Cannot find module 'angular2/core'.
node_modules/ng2-bootstrap/components/datepicker/datepicker-inner.component.ts(91,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<Date>'.
  Type '{}' is not assignable to type 'Date'.
    Property 'toDateString' is missing in type '{}'.
node_modules/ng2-bootstrap/components/dropdown/dropdown.directive.ts(20,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<boolean>'.
  Type '{}' is not assignable to type 'boolean'.
node_modules/ng2-bootstrap/components/dropdown/dropdown.directive.ts(21,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<boolean>'.
  Type '{}' is not assignable to type 'boolean'.
node_modules/ng2-bootstrap/components/pagination/pagination.component.ts(95,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<number>'.
  Type '{}' is not assignable to type 'number'.
node_modules/ng2-bootstrap/components/pagination/pagination.component.ts(96,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<PageChangedEvent>'.
  Type '{}' is not assignable to type 'PageChangedEvent'.
    Property 'itemsPerPage' is missing in type '{}'.
node_modules/ng2-bootstrap/components/rating/rating.component.ts(33,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<number>'.
  Type '{}' is not assignable to type 'number'.
node_modules/ng2-bootstrap/components/rating/rating.component.ts(34,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<number>'.
  Type '{}' is not assignable to type 'number'.
node_modules/ng2-bootstrap/components/tabs/tab.directive.ts(21,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<TabDirective>'.
  Type '{}' is not assignable to type 'TabDirective'.
    Property 'heading' is missing in type '{}'.
node_modules/ng2-bootstrap/components/tabs/tab.directive.ts(22,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<TabDirective>'.
  Type '{}' is not assignable to type 'TabDirective'.
node_modules/ng2-bootstrap/components/tabs/tab.directive.ts(23,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<TabDirective>'.
  Type '{}' is not assignable to type 'TabDirective'.
node_modules/ng2-bootstrap/components/typeahead/typeahead.directive.ts(24,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<boolean>'.
  Type '{}' is not assignable to type 'boolean'.
node_modules/ng2-bootstrap/components/typeahead/typeahead.directive.ts(25,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<boolean>'.
  Type '{}' is not assignable to type 'boolean'.
node_modules/ng2-bootstrap/components/typeahead/typeahead.directive.ts(26,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<{ item: any; }>'.
  Type '{}' is not assignable to type '{ item: any; }'.
    Property 'item' is missing in type '{}'.

laurelnaiad · 2016-05-06T20:15:30Z

"rxjs": "5.0.0-beta.2"

is incorrect. It should be pointing at beta 6 at minimum.

This was one ot the reasons I adjusted the deps in my branch above (https://github.com/laurelnaiad/ng2-bootstrap/commit/8db45570e724cd8806828671fed524b67f9f6a79)

ps2goat · 2016-05-06T21:05:07Z

@theunreal - EventEmitters now need type specifications when being initialized.

E.g.:

let x: EventEmitter<string> = new EventEmitter<string>();

This was previously done like this:
let x: EventEmitter<string> = new EventEmitter();

btw, this error does not show up in Visual Studio Update 2, only when I compile with gulp-typescript and typescript 1.8.10. We're coming off of 1.7.5, though, so I don't know about anything in-between.

ps2goat · 2016-05-06T21:07:15Z

+1 for RC 1 support

valorkin · 2016-05-06T21:07:38Z

Thanks to all of you guys!
Just published

valorkin · 2016-05-06T21:08:05Z

Can someone PR all contributors manifest support? :)

Use dynamic versions of platform-browser bundle

3c47c7f

This was referenced May 3, 2016

Support Angular 2.0.0-rc.0 (2016-05-02) #477

Closed

bug(rating): There is no directive with "exportAs" set to "index" #482

Closed

francesconi reviewed May 4, 2016
View reviewed changes

Add missing quote

be8700f

Upgrade to angular 2.0.0-rc.1

3e50b0f

ciriarte changed the title ~~Upgrade ng2-bootstrap to rc.0~~ Upgrade ng2-bootstrap to rc.1 May 4, 2016

theunreal mentioned this pull request May 6, 2016

New errors with RC.0 #487

Closed

valorkin merged commit 554be3d into valor-software:development May 6, 2016

hongbo-miao mentioned this pull request May 6, 2016

Support .beta.17 #470

Closed

valorkin mentioned this pull request May 7, 2016

CAROUSEL_DIRECTIVES: deprecate use of *ngFor="#slidez of slides", throws template parsing error in Angular2.0.0.beta.17 #484

Closed

This was referenced May 7, 2016

Angular2.beta.17 causes datepicker to fail with a template parse error #480

Closed

Can you please update angular2 version from beta 16 to beta 17 #471

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ng2-bootstrap to rc.1 #481

Upgrade ng2-bootstrap to rc.1 #481

ciriarte commented May 3, 2016 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

hhsadiq commented May 4, 2016

coutin commented May 4, 2016

ciriarte commented May 4, 2016

laurelnaiad commented May 5, 2016

ciriarte commented May 6, 2016

rodolfocop commented May 6, 2016

valorkin commented May 6, 2016

valorkin commented May 6, 2016

laurelnaiad commented May 6, 2016

hongbo-miao commented May 6, 2016 •

edited

Loading

laurelnaiad commented May 6, 2016

valorkin commented May 6, 2016

rodolfocop commented May 6, 2016

theunreal commented May 6, 2016 •

edited

Loading

laurelnaiad commented May 6, 2016 •

edited

Loading

ps2goat commented May 6, 2016 •

edited

Loading

ps2goat commented May 6, 2016

valorkin commented May 6, 2016

valorkin commented May 6, 2016

Upgrade ng2-bootstrap to rc.1 #481

Upgrade ng2-bootstrap to rc.1 #481

Conversation

ciriarte commented May 3, 2016 • edited Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

hhsadiq commented May 4, 2016

coutin commented May 4, 2016

ciriarte commented May 4, 2016

laurelnaiad commented May 5, 2016

ciriarte commented May 6, 2016

rodolfocop commented May 6, 2016

valorkin commented May 6, 2016

valorkin commented May 6, 2016

laurelnaiad commented May 6, 2016

hongbo-miao commented May 6, 2016 • edited Loading

laurelnaiad commented May 6, 2016

valorkin commented May 6, 2016

rodolfocop commented May 6, 2016

theunreal commented May 6, 2016 • edited Loading

laurelnaiad commented May 6, 2016 • edited Loading

ps2goat commented May 6, 2016 • edited Loading

ps2goat commented May 6, 2016

valorkin commented May 6, 2016

valorkin commented May 6, 2016

ciriarte commented May 3, 2016 •

edited

Loading

hongbo-miao commented May 6, 2016 •

edited

Loading

theunreal commented May 6, 2016 •

edited

Loading

laurelnaiad commented May 6, 2016 •

edited

Loading

ps2goat commented May 6, 2016 •

edited

Loading