Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(date-picker): remove redundant code #4863

Merged
merged 4 commits into from
Dec 13, 2018
Merged

refactor(date-picker): remove redundant code #4863

merged 4 commits into from
Dec 13, 2018

Conversation

danielsogl
Copy link
Contributor

@danielsogl danielsogl commented Dec 1, 2018 •
edited
Loading

No description provided.

@ghost ghost added the needs review label Dec 1, 2018
@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #4863 into development will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4863      +/-   ##
===============================================
- Coverage        75.69%   75.65%   -0.05%     
===============================================
  Files              237      237              
  Lines             7336     7336              
  Branches          1464     1464              
===============================================
- Hits              5553     5550       -3     
- Misses            1376     1378       +2     
- Partials           407      408       +1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 69.44% <0%> (-8.34%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1662554...de3b908. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 1, 2018 •
edited
Loading

Codecov Report

Merging #4863 into development will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4863      +/-   ##
===============================================
- Coverage        74.88%   74.83%   -0.06%     
===============================================
  Files              276      276              
  Lines             8399     8402       +3     
  Branches          1596     1596              
===============================================
- Hits              6290     6288       -2     
- Misses            1669     1671       +2     
- Partials           440      443       +3
Impacted Files Coverage Δ
...c/datepicker/bs-daterangepicker-input.directive.ts 24.7% <0%> (-0.91%) ⬇️
src/datepicker/engine/flag-days-calendar.ts 75% <0%> (-6.25%) ⬇️
src/chronos/i18n/pl.ts 71.79% <0%> (-2.57%) ⬇️
src/chronos/utils/date-getters.ts 79.54% <0%> (-2.28%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 74.31% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92efe9a...4368739. Read the comment docs.

valorkin
valorkin requested changes Dec 6, 2018
View reviewed changes
src/datepicker/bs-daterangepicker-input.directive.ts Outdated
@@ -107,7 +107,7 @@ export class BsDaterangepickerInputDirective
}


const _isDateValid = isDateValid(_value[0]) && isDateValid(_value[0]);
const _isDateValid = isDateValid(_value[0]);

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@valorkin valorkin added this to the 3.1.4 milestone Dec 8, 2018
@ghost ghost assigned Domainv Dec 13, 2018
valorkin
valorkin approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@valorkin valorkin merged commit bf07304 into valor-software:development Dec 13, 2018
@ghost ghost removed the ready for merge label Dec 13, 2018
@danielsogl danielsogl deleted the patch-1 branch December 14, 2018 21:00
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@danielsogl @leo6104
refactor(date-picker): remove redundant code (valor-software#4863)
57a52ac 
* refactor(date-picker): remove redundant code

* fix(datepicker): add report invalid date in range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees

@Domainv Domainv

Labels
comp(datepicker)
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@danielsogl @valorkin @Domainv @ludmilanesvitiy