fix(typeahead): fix typeahead's breaking if typeahead property receives NULL #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## development #4957 +/- ##
==============================================
+ Coverage 74.79% 74.8% +0.01%
==============================================
Files 277 277
Lines 8434 8434
Branches 1602 1603 +1
==============================================
+ Hits 6308 6309 +1
+ Misses 1683 1679 -4
- Partials 443 446 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #4957 +/- ##
===============================================
+ Coverage 74.79% 74.83% +0.04%
===============================================
Files 277 277
Lines 8434 8436 +2
Branches 1602 1603 +1
===============================================
+ Hits 6308 6313 +5
+ Misses 1678 1677 -1
+ Partials 448 446 -2
Continue to review full report at Codecov.
|
valorkin
requested changes
Dec 21, 2018
src/typeahead/typeahead.directive.ts
Outdated
| @@ -448,6 +448,9 @@ export class TypeaheadDirective implements OnInit, OnDestroy { | |||
| } | |||
|
|
|||
| protected finalizeAsyncCall(matches: TypeaheadMatch[]): void { | |||
| if (!matches) { | |||
| return; | |||
There was a problem hiding this comment.
Suggested change
| return; | |
| matches = []; |
| @@ -78,6 +78,9 @@ export class DemoTypeaheadAsyncComponent { | |||
|
|
|||
| getStatesAsObservable(token: string): Observable<any> { | |||
| const query = new RegExp(token, 'i'); | |||
| if (!this.statesComplex) { | |||
valorkin
approved these changes
Dec 21, 2018
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
…es NULL (valor-software#4957) * fix(typeahead): Typeahead breaks if typeahead property receives NULL * fix(typeahead): restore typehead-directive file * feat(typeahead): add tests for new func * fix(typeahead): rework existing pr Fixes valor-software#4417
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
…es NULL (valor-software#4957) * fix(typeahead): Typeahead breaks if typeahead property receives NULL * fix(typeahead): restore typehead-directive file * feat(typeahead): add tests for new func * fix(typeahead): rework existing pr Fixes valor-software#4417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes to #4417