fix(tabs): adding tab content to DOM just if selected tab (#1422) #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
llysenko
force-pushed
the
fix-tabs-init
branch
2 times, most recently
from
ce661fd to
9f2bcf8
Compare
Codecov Report
@@ Coverage Diff @@
## development #4991 +/- ##
===============================================
- Coverage 74.79% 74.76% -0.03%
===============================================
Files 277 277
Lines 8436 8450 +14
Branches 1603 1605 +2
===============================================
+ Hits 6310 6318 +8
- Misses 1680 1684 +4
- Partials 446 448 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #4991 +/- ##
===============================================
- Coverage 74.79% 74.71% -0.09%
===============================================
Files 277 277
Lines 8436 8450 +14
Branches 1603 1605 +2
===============================================
+ Hits 6310 6313 +3
- Misses 1680 1691 +11
Partials 446 446
Continue to review full report at Codecov.
|
llysenko
force-pushed
the
fix-tabs-init
branch
from
9f2bcf8 to
adf694c
Compare
Domainv
approved these changes
Jan 10, 2019
ludmilanesvitiy
added
in test
ready for merge
and removed
ready for tests
in test
labels
|
Tabs new demo and previous functionality - tested, looks good. Also will be nice to merge this PR #4946 first |
valorkin
approved these changes
Feb 8, 2019
valorkin
pushed a commit
that referenced
this pull request
Feb 8, 2019
|
This change appears in the release note, but seems to be reverted. What is the status of this? Will it be added to the next release? |
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
Close #1422