Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix fail on target=es6 #5123

Merged
merged 3 commits into from
Mar 26, 2019
Merged

fix(build): fix fail on target=es6 #5123

merged 3 commits into from
Mar 26, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Mar 25, 2019

Closes #5086

For testing:

  • npm run build
  • ./tsconfig.json change target to es6
  • ng serve

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #5123 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5123   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d1c39...14b326c. Read the comment docs.

@Domainv Domainv added this to the 4.0.1 milestone Mar 25, 2019
@ludmilanesvitiy
Copy link
Contributor

Smoke tested, looks good.

@Domainv Domainv merged commit 5a3afe3 into development Mar 26, 2019
@ghost ghost removed the ready for merge label Mar 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-target-es6 branch March 26, 2019 20:48
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants