Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): add Latvian locale (#hacktoberfest) #5432

Merged
merged 3 commits into from
Oct 28, 2019
Merged

feat(datepicker): add Latvian locale (#hacktoberfest) #5432

merged 3 commits into from
Oct 28, 2019

Conversation

MatissJanis
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@MatissJanis MatissJanis changed the title Added Latvian locale Added Latvian locale (#hacktoberfest) Oct 6, 2019
@daniloff200 daniloff200 requested a review from Domainv October 6, 2019 14:54
@daniloff200
Copy link
Contributor

hey @MatissJanis !
Thanks for your contribution!
Can you please check both #5387 or #4812 or https://github.com/valor-software/ngx-bootstrap/pull/4634/files as examples of good localization?
There's not only one file, you have to add this files as an import in different places

Also, add tests for it will be very good!

daniloff200
daniloff200 suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add locale as an import / export, and add tests

@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #5432 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5432   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecb873...0a804ad. Read the comment docs.

@MatissJanis
Copy link
Contributor Author

Thanks @daniloff200 ! Added tests, exposed import/export and fixed some bugs in the process 🙂

Let me know if anything else is wrong/missing.

@daniloff200
Copy link
Contributor

Thanks for the fixes @MatissJanis ! Well, I think, that's pretty enough.
@Domainv thoughts? Can we merge it for next release ?

@Domainv Domainv added this to the 5.4.0 milestone Oct 28, 2019
@Domainv Domainv changed the title Added Latvian locale (#hacktoberfest) feat(datepicker): add Latvian locale (#hacktoberfest) Oct 28, 2019
@Domainv Domainv merged commit 9df0788 into valor-software:development Oct 28, 2019
@MatissJanis
Copy link
Contributor Author

Thanks guys!

@daniloff200
Copy link
Contributor

hey @MatissJanis !
Thanks again for the PR!
Could you please fill out this form so we can send some swag to you? Thanks!

@Domainv Domainv removed this from the 5.4.0 milestone Oct 28, 2019
@daniloff200 daniloff200 mentioned this pull request Nov 2, 2019
Closed
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
@MatissJanis @IraErshova
feat(datepicker): add Latvian locale (#hacktoberfest) (valor-software…
c4f24b2 
…#5432)

* Create lv.ts

* Add tests & expose interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domainv Domainv Domainv approved these changes

@daniloff200 daniloff200 daniloff200 approved these changes

Assignees
No one assigned
Labels
comp(datepicker)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatissJanis @daniloff200 @Domainv