Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): fix of file name mistake #5457

Merged
merged 3 commits into from
Oct 14, 2019
Merged

fix(doc): fix of file name mistake #5457

merged 3 commits into from
Oct 14, 2019

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Oct 9, 2019

correct name of file
from tooltip.examles.placement.use-case.md -> tooltip.examples.placement.use-case.md

closes #5456

@sameshl
rename file
ebaaf8c 
correct name of file
from tooltip.examles.placement.use-case.md -> tooltip.examples.placement.use-case.md

closes #5456
@daniloff200 daniloff200 self-requested a review October 9, 2019 15:08
daniloff200
daniloff200 suggested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip.examlpes.placement.use-case.md

🤔

@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #5457 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5457   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906f4a4...88b5ecc. Read the comment docs.

@sameshl
Copy link
Contributor Author

sameshl commented Oct 9, 2019

@daniloff200 My bad 😅. Made the correction

@daniloff200 daniloff200 mentioned this pull request Oct 10, 2019
Closed
5 tasks
@sameshl sameshl mentioned this pull request Oct 10, 2019
Closed
This was referenced Oct 11, 2019
Closed
Closed
Closed
Closed
@Domainv Domainv changed the title rename file fix(doc): fix of file name mistake Oct 14, 2019
@Domainv Domainv merged commit 13bba2e into valor-software:development Oct 14, 2019
@daniloff200
Copy link
Contributor

hi @sameshl !
Thanks again for the PR!
Could you please fill out this form so we can send some swag to you? Thanks!

@sameshl sameshl deleted the fix_name branch October 18, 2019 01:16
@sameshl
Copy link
Contributor Author

sameshl commented Oct 18, 2019

Thanks @daniloff200 Will do!

IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
@sameshl @IraErshova
fix(doc): fix of file name mistake (valor-software#5457)
fd5b240 
* rename file

correct name of file
from tooltip.examles.placement.use-case.md -> tooltip.examples.placement.use-case.md

closes valor-software#5456

* fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domainv Domainv Domainv approved these changes

@daniloff200 daniloff200 daniloff200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong file name
3 participants
@sameshl @daniloff200 @Domainv