Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix tooltip appearing after it has been destroyed #5548

Conversation

reimavronicolas
Copy link
Contributor

@reimavronicolas reimavronicolas commented Nov 14, 2019

closes #5217

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@reimavronicolas reimavronicolas changed the title fix(tooltip): fix tooltip appearing after it has been destroyed (#5217) fix(tooltip): fix tooltip appearing after it has been destroyed Nov 14, 2019
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #5548 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5548      +/-   ##
===============================================
- Coverage        73.66%   73.63%   -0.03%     
===============================================
  Files              323      323              
  Lines            11637    11641       +4     
  Branches          2475     2477       +2     
===============================================
  Hits              8572     8572              
- Misses            1964     1967       +3     
- Partials          1101     1102       +1     
Impacted Files Coverage Δ
src/tooltip/tooltip.directive.ts 67.51% <0.00%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09354e6...dcadb56. Read the comment docs.

valorkin
valorkin previously approved these changes Jan 13, 2020
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! but popover will have the same issue :)

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniloff200 daniloff200 merged commit db437f3 into valor-software:development Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip stay on the left top corner when spam click
4 participants