Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapse): "Collapse" component breaks "Dropdown component #5625 #5626

Merged
merged 2 commits into from Feb 3, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2020

Delete overflow style for the active collapse

Close #5625

Why issue happened

When the "collapse div" is going to be collapsed for the first time, "overflow: hidden" is added to it's styles, and then, when block opens back, this rule isn't removed.

PR Checklist

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #5626 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5626   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50b54e...c25bbcb. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution

@daniloff200 daniloff200 merged commit 0b4721d into valor-software:development Feb 3, 2020
@dmitry-zhemchugov dmitry-zhemchugov removed their assignment Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Collapse" component breaks "Dropdown" component
4 participants