Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): add more cases for on blur logic #5629

Merged
merged 5 commits into from
Feb 26, 2020

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Jan 30, 2020

closes #5360

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@daniloff200 daniloff200 changed the title feat(typeahead): add more on blur logic feat(typeahead): add more cases for on blur logic Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #5629 into development will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5629      +/-   ##
===============================================
- Coverage        73.66%   73.65%   -0.01%     
===============================================
  Files              323      323              
  Lines            11614    11618       +4     
  Branches          2473     2475       +2     
===============================================
+ Hits              8555     8557       +2     
- Misses            1962     1965       +3     
+ Partials          1097     1096       -1     
Impacted Files Coverage Δ
...ker/themes/bs/bs-months-calendar-view.component.ts 56.25% <0.00%> (-12.50%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 74.07% <0.00%> (-1.49%) ⬇️
src/typeahead/typeahead.directive.ts 79.92% <0.00%> (-1.21%) ⬇️
.../datepicker/bs-daterangepicker-inline.component.ts 62.35% <0.00%> (+1.17%) ⬆️
src/datepicker/utils/bs-calendar-utils.ts 84.84% <0.00%> (+6.06%) ⬆️
...themes/bs/bs-datepicker-day-decorator.directive.ts 81.48% <0.00%> (+7.40%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 82.85% <0.00%> (+8.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23800f5...8803e2d. Read the comment docs.

@daniloff200 daniloff200 removed the WIP label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur event inconsistent on typeahead
3 participants