-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typeahead): add feature to do multiple search w/ specified delimiter #5784
feat(typeahead): add feature to do multiple search w/ specified delimiter #5784
Conversation
…iter feature allows to show typeahead dropdown even after any value already entered by typing one of provided delimiters to be able to pick again; keeps all searched values, described in valor-software#5781 Closes valor-software#5781
@valorkin @daniloff200 Please review this feature as soon as possible. I added demo, tests, all that required. I desperately need it in my project. |
Codecov Report
@@ Coverage Diff @@
## development #5784 +/- ##
==============================================
Coverage ? 73.75%
==============================================
Files ? 323
Lines ? 11689
Branches ? 2487
==============================================
Hits ? 8621
Misses ? 1961
Partials ? 1107
Continue to review full report at Codecov.
|
hey, @lehetap |
Well, I've checked that feature, looks really awesome! Gonna check units and e2e's and, if everything works well, merge that |
Thank you! I'm glad everything worked out well! |
feature allows to show typeahead dropdown even after any value
already entered by typing one of provided delimiters to be able to pick
again; keeps all searched values, described in #5781
Closes #5781
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.