Switch to generic ModuleWithProviders #5794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For Ivy compatibility per: https://angular.io/guide/migration-module-with-providers Signed-off-by: Jon Stelly <967068+jonstelly@users.noreply.github.com>
|
oh, I wish, I saw this PR earlier :( Thanks for your contribution, but, I've made almost the same changes in #5812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply switched to returning the generic version of ModuleWithProviders. According to the version compatibility chart, ngx-bootstrap is compatible with angular 7+ and the generic ModuleWithProviders<> was added in Angular 7.
I ran tests locally and saw no issues. I'm submitting this because I'm getting some build errors when I try to build one of my internal libraries targeting Ivy.
Signed-off-by: Jon Stelly 967068+jonstelly@users.noreply.github.com
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.