Emitting event when datepicker selection is done #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, looks good |
|
just in case, usually docs update is required :) |
|
@valorkin I did not expect you will merge this PR so fast - of course next time I will update docs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @valorkin,
In my project I need to have datepicker 'popup' functionality ASAP. I decided to add an event to datepicker which fires when date selection is done (picker reached minMode). Additionally, I don't want to use ngModel two way binding since it changes model value event when selection is not yet done (I want to select month, but I'm on a year view - clicking year changes model which is unacceptable for me). In this PR, I use selectionDone event to both receive selected date and as a signal to close datepicker popup.
This can be useful in #273