try to fix #929 by importing FormsModule because the selectors use [ngModel] #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.39% (diff: 100%)
@@ development #931 diff @@
=============================================
Files 26 26
Lines 780 781 +1
Methods 142 142
Messages 0 0
Branches 115 115
=============================================
+ Hits 705 706 +1
Misses 75 75
Partials 0 0
|
…because every template which uses such a module would anyway import FormsModul which is now no longer necessary
|
Agreed, this should fix an issue, let me check it locally |
jtomaszewski
pushed a commit
to jtomaszewski/ng2-bootstrap
that referenced
this pull request
Oct 22, 2016
…esent (valor-software#931) * try to fix valor-software#929 by importing FormsModule because the selectors use [ngModel] * export FormsModule in all modules which use ngModel selector binding because every template which uses such a module would anyway import FormsModul which is now no longer necessary fixes valor-software#929
Gxerxes
pushed a commit
to Gxerxes/ng2-bootstrap
that referenced
this pull request
Oct 28, 2016
…esent (valor-software#931) * try to fix valor-software#929 by importing FormsModule because the selectors use [ngModel] * export FormsModule in all modules which use ngModel selector binding because every template which uses such a module would anyway import FormsModul which is now no longer necessary fixes valor-software#929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix #929 by importing FormsModule because the selectors use [ngModel]